From: Peng Fan <peng.fan@nxp.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: "djakov@kernel.org" <djakov@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
Abel Vesa <abel.vesa@nxp.com>,
"abailon@baylibre.com" <abailon@baylibre.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"marex@denx.de" <marex@denx.de>,
"paul.elder@ideasonboard.com" <paul.elder@ideasonboard.com>,
"Markus.Niebel@ew.tq-group.com" <Markus.Niebel@ew.tq-group.com>,
"aford173@gmail.com" <aford173@gmail.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 1/8] dt-bindings: soc: imx: add interconnect property for i.MX8MP media blk ctrl
Date: Mon, 13 Jun 2022 01:03:04 +0000 [thread overview]
Message-ID: <DU0PR04MB941724785E173EA71DEF3FE088AB9@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <YpvRL4d2Sh9hvVMl@pendragon.ideasonboard.com>
> Subject: Re: [PATCH 1/8] dt-bindings: soc: imx: add interconnect property for
> i.MX8MP media blk ctrl
>
> Hi Peng,
>
> Thank you for the patch.
>
> On Wed, Jun 01, 2022 at 05:45:30PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add interconnect property for i.MX8MP mediamix blk ctrl
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > .../soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.
> > yaml
> > b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.
> > yaml index 21d3ee486295..706bef39b87e 100644
> > ---
> > a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.
> > yaml
> > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-c
> > +++ trl.yaml
> > @@ -64,6 +64,20 @@ properties:
> > - const: isp
> > - const: phy
> >
> > + interconnects:
> > + maxItems: 8
> > +
> > + interconnect-names:
> > + items:
> > + - const: lcdif-rd
> > + - const: lcdif-wr
> > + - const: isi0
> > + - const: isi1
> > + - const: isi2
>
> If I understand correctly, these are for the 1x RD and 2x WR channels of the ISI.
> Would it make sense to name thim accordingly, maybe isi-rd,
> isi-wr0 and isi-wr1 ? I'm not sure about the order though.
From the doc I get, they are isi0/1/2, so I would keep them as it is.
Thanks,
Peng.
>
> > + - const: isp0
> > + - const: isp1
> > + - const: dwe
> > +
> > required:
> > - compatible
> > - reg
>
> --
> Regards,
>
> Laurent Pinchart
next prev parent reply other threads:[~2022-06-13 1:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 9:45 [PATCH 0/8] Add interconnect for i.MX8MP blk ctrl Peng Fan (OSS)
2022-06-01 9:45 ` [PATCH 1/8] dt-bindings: soc: imx: add interconnect property for i.MX8MP media " Peng Fan (OSS)
2022-06-01 11:52 ` Krzysztof Kozlowski
2022-06-04 21:39 ` Laurent Pinchart
2022-06-13 1:03 ` Peng Fan [this message]
2022-06-01 9:45 ` [PATCH 2/8] dt-bindings: soc: imx: add interconnect property for i.MX8MP hdmi " Peng Fan (OSS)
2022-06-01 11:52 ` Krzysztof Kozlowski
2022-06-01 9:45 ` [PATCH 3/8] dt-bindings: soc: imx: add interconnect property for i.MX8MP hsio " Peng Fan (OSS)
2022-06-01 11:52 ` Krzysztof Kozlowski
2022-06-01 9:45 ` [PATCH 4/8] soc: imx: add icc paths for i.MX8MP media " Peng Fan (OSS)
2022-06-04 21:44 ` Laurent Pinchart
2022-06-13 1:17 ` Peng Fan
2022-06-29 15:40 ` Lucas Stach
2022-07-02 12:56 ` Peng Fan
2022-06-01 9:45 ` [PATCH 5/8] soc: imx: add icc paths for i.MX8MP hsio/hdmi " Peng Fan (OSS)
2022-06-01 9:45 ` [PATCH 6/8] arm64: dts: imx8mp: add NoC node Peng Fan (OSS)
2022-06-29 15:21 ` Lucas Stach
2022-07-02 12:52 ` Peng Fan
2022-06-01 9:45 ` [PATCH 7/8] arm64: dts: imx8mp: add interconnects for media blk ctrl Peng Fan (OSS)
2022-06-01 9:45 ` [PATCH 8/8] arm64: dts: imx8mp: add interconnect for hsio " Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DU0PR04MB941724785E173EA71DEF3FE088AB9@DU0PR04MB9417.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=abailon@baylibre.com \
--cc=abel.vesa@nxp.com \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marex@denx.de \
--cc=paul.elder@ideasonboard.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).