From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: edubezval@gmail.com, kevin.wangtao@linaro.org,
leo.yan@linaro.org, vincent.guittot@linaro.org,
linux-kernel@vger.kernel.org, javi.merino@kernel.org,
rui.zhang@intel.com, daniel.thompson@linaro.org,
linux-pm@vger.kernel.org,
Amit Daniel Kachhap <amit.kachhap@gmail.com>
Subject: Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver
Date: Wed, 11 Apr 2018 11:29:53 +0200 [thread overview]
Message-ID: <a1533926-0d9b-248a-96e9-e3148b4d9f08@linaro.org> (raw)
In-Reply-To: <20180411085130.GN7671@vireshk-i7>
Hi Viresh,
thanks for the review.
On 11/04/2018 10:51, Viresh Kumar wrote:
[ ... ]
>> +void __init cpuidle_cooling_register(void)
>> +{
>> + struct cpuidle_cooling_device *idle_cdev = NULL;
>> + struct thermal_cooling_device *cdev;
>> + struct device_node *np;
>> + cpumask_var_t cpumask;
>
> maybe call it clustermask ?
Yeah, sounds better.
>> + cdev = thermal_of_cooling_device_register(np, dev_name,
>> + idle_cdev,
>> + &cpuidle_cooling_ops);
>> + if (IS_ERR(cdev)) {
>> + ret = PTR_ERR(cdev);
>> + goto out;
>> + }
>> +
>> + idle_cdev->cdev = cdev;
>> + cpumask_set_cpu(cluster_id, cpumask);
>> + }
>> +
>> + ret = smpboot_register_percpu_thread(&cpuidle_cooling_threads);
>> + if (ret)
>> + goto out;
>> +
>> + pr_info("Created cpuidle cooling device\n");
>> +out:
>> + free_cpumask_var(cpumask);
>> +
>> + if (ret) {
>> + cpuidle_cooling_unregister();
>> + pr_err("Failed to create idle cooling device (%d)\n", ret);
>> + }
>
> Maybe rearrange it a bit:
>
> + ret = smpboot_register_percpu_thread(&cpuidle_cooling_threads);
> +
> +out:
> + if (ret) {
> + cpuidle_cooling_unregister();
> + pr_err("Failed to create idle cooling device (%d)\n", ret);
> + } else {
> + pr_info("Created cpuidle cooling devices\n");
> + }
> +
> + free_cpumask_var(cpumask);
>
> ??
I usually tend to avoid using 'else' statements when possible (a coding
style practice) but if you prefer this version I'm fine with that.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-04-11 9:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 16:16 [PATCH v3 0/7] CPU cooling device new strategies Daniel Lezcano
2018-04-05 16:16 ` [PATCH v3 1/7] thermal/drivers/cpu_cooling: Fixup the header and copyright Daniel Lezcano
[not found] ` <20180411061514.GL7671@vireshk-i7>
2018-04-11 8:56 ` Daniel Lezcano
2018-04-05 16:16 ` [PATCH v3 2/7] thermal/drivers/cpu_cooling: Add Software Package Data Exchange (SPDX) Daniel Lezcano
2018-04-05 16:16 ` [PATCH v3 3/7] thermal/drivers/cpu_cooling: Remove pointless field Daniel Lezcano
2018-04-05 16:16 ` [PATCH v3 4/7] thermal/drivers/Kconfig: Convert the CPU cooling device to a choice Daniel Lezcano
[not found] ` <20180411061851.GM7671@vireshk-i7>
2018-04-11 8:58 ` Daniel Lezcano
2018-04-05 16:16 ` [PATCH v3 5/7] thermal/drivers/cpu_cooling: Add idle cooling device documentation Daniel Lezcano
2018-04-05 16:16 ` [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver Daniel Lezcano
2018-04-11 8:51 ` Viresh Kumar
2018-04-11 9:29 ` Daniel Lezcano [this message]
2018-04-13 11:23 ` Sudeep Holla
2018-04-13 11:47 ` Daniel Lezcano
2018-04-16 7:37 ` Viresh Kumar
2018-04-16 7:44 ` Daniel Lezcano
2018-04-16 9:34 ` Sudeep Holla
2018-04-16 9:37 ` Viresh Kumar
2018-04-16 9:45 ` Daniel Lezcano
2018-04-16 9:50 ` Viresh Kumar
2018-04-16 10:03 ` Daniel Lezcano
2018-04-16 10:10 ` Viresh Kumar
2018-04-16 12:10 ` Daniel Lezcano
2018-04-16 12:30 ` Lorenzo Pieralisi
2018-04-16 13:57 ` Daniel Lezcano
2018-04-16 14:22 ` Lorenzo Pieralisi
2018-04-17 7:17 ` Daniel Lezcano
2018-04-17 10:24 ` Lorenzo Pieralisi
2018-04-16 12:31 ` Sudeep Holla
2018-04-16 12:49 ` Daniel Lezcano
2018-04-16 13:03 ` Sudeep Holla
2018-04-16 12:29 ` Sudeep Holla
2018-04-13 11:38 ` Daniel Thompson
2018-04-13 11:46 ` Daniel Lezcano
2019-08-05 5:11 ` Martin Kepplinger
2019-08-05 6:53 ` Martin Kepplinger
2019-08-05 7:39 ` Daniel Lezcano
2019-08-05 7:42 ` Martin Kepplinger
2019-08-05 7:58 ` Daniel Lezcano
2019-10-25 11:22 ` Martin Kepplinger
2019-10-25 14:45 ` Daniel Lezcano
2019-10-26 18:23 ` Martin Kepplinger
2019-10-28 15:16 ` Daniel Lezcano
2019-08-05 7:37 ` Daniel Lezcano
2019-08-05 7:40 ` Martin Kepplinger
2018-04-05 16:16 ` [PATCH v3 7/7] cpuidle/drivers/cpuidle-arm: Register the cooling device Daniel Lezcano
2018-04-11 8:51 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1533926-0d9b-248a-96e9-e3148b4d9f08@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=edubezval@gmail.com \
--cc=javi.merino@kernel.org \
--cc=kevin.wangtao@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).