Re: Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow)

["Kenneth R. Crudup" <kenny@panix.com>]

On Mon, 25 Nov 2019, Rafael J. Wysocki wrote:

> OK, but with sleep_no_lps0, does it also hang during resume or not?

It never goes to sleep, is what I'm saying. Screen goes dark, but the machine
seems to never go into sleep states.

> In that case whatever happens in acpi_s2idle_wake() can be ruled out,
> because on your system that function effectively is a NOP with
> ec_no_wakeup.  I don't expect the test below to add anything new to
> what we know already.

> > >         acpi_os_wait_events_complete(); /* synchronize EC GPE processing */
> > >         acpi_ec_flush_work();
> > >         acpi_os_wait_events_complete(); /* synchronize Notify handling */

> So, as stated above, this test is not likely to be conclusive.

I dunno ... did you see my other E-mail? Other than power-charge events
waking up my laptop (and not going to sleep while plugged in), it hasn't
hung up in several resume attempts, and doing power changes while asleep
just wakes it up (be it charger being plugged in, or charger removed).

Maybe this is expected behavor with those lines commented out, but at least
I know now that it's possible to suspend and successfully resume under my
standard workflow on a later-model kernel.

> I'll send you a patch to try for that.

I see that's in your next E-mail. I'll try it out shortly.

	-Kenny

-- 
Kenneth R. Crudup  Sr. SW Engineer, Scott County Consulting, Silicon Valley