From: Jonas Meurer <jonas@freesources.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Tim Dittler <tim.dittler@systemli.org>,
Yannik Sembritzki <yannik@sembritzki.me>
Subject: Re: [PATCH 2/2] PM: CONFIG_SUSPEND_SKIP_SYNC sets default for, '/sys/power/sync_on_suspend'
Date: Fri, 20 Dec 2019 17:06:07 +0100 [thread overview]
Message-ID: <bc340a6c-aa00-82d0-95a1-809914fb2b44@freesources.org> (raw)
In-Reply-To: <5078963.9SuZRVoKLz@kreacher>
Hey Rafael,
Rafael J. Wysocki:
> On Monday, December 2, 2019 6:07:43 PM CET Jonas Meurer wrote:
>> Slightly change the behaviour of build-time switch CONFIG_SUSPEND_SKIP_SYNC:
>> Make it configure the default for '/sys/power/sync_on_suspend', now that we
>> have a run-time switch for it.
>> [...]
>
> I don't see much value in splitting the changes into two patches.
> On the contrary, this patch is a logical part of the full change, so IMO
> it should be folded into the [1/2].
>
> Please do so and resubmit.
Thanks for looking into the patch!
I resubmitted it now as a single patch:
[PATCH v2] PM: Add a switch for disabling/enabling sync() before suspend
Kind regards
jonas
next prev parent reply other threads:[~2019-12-20 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 17:05 [PATCH 0/2] PM: Add a switch for disabling/enabling sync() before suspend Jonas Meurer
2019-12-02 17:07 ` [PATCH 1/2] PM: Add a switch for disabling/enabling sync() before, suspend Jonas Meurer
2019-12-14 9:13 ` Pavel Machek
2019-12-16 16:54 ` Jonas Meurer
2019-12-02 17:07 ` [PATCH 2/2] PM: CONFIG_SUSPEND_SKIP_SYNC sets default for, '/sys/power/sync_on_suspend' Jonas Meurer
2019-12-20 9:35 ` Rafael J. Wysocki
2019-12-20 16:06 ` Jonas Meurer [this message]
2019-12-11 15:59 ` [PATCH 0/2] PM: Add a switch for disabling/enabling sync() before suspend Jonas Meurer
2019-12-12 18:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc340a6c-aa00-82d0-95a1-809914fb2b44@freesources.org \
--to=jonas@freesources.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tim.dittler@systemli.org \
--cc=yannik@sembritzki.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).