From: Jiri Slaby <jirislaby@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>, Jeongjun Park <aha310510@gmail.com>
Cc: syzbot+393d0ef63475d9bb1f16@syzkaller.appspotmail.com,
davem@davemloft.net, edumazet@google.com,
linux-kernel@vger.kernel.org, linux-ppp@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com,
gregkh@linuxfoundation.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH net,v3] net: ppp: Fix deadlock caused by unsafe-irq lock in ap_get()
Date: Mon, 22 Apr 2024 08:39:58 +0200 [thread overview]
Message-ID: <0032f249-7787-4875-a782-0847c04d5c9c@kernel.org> (raw)
In-Reply-To: <20240419173108.30cf9090@kernel.org>
On 20. 04. 24, 2:31, Jakub Kicinski wrote:
> On Sat, 20 Apr 2024 03:38:15 +0900 Jeongjun Park wrote:
>> read_lock() present in ap_get() is interrupt-vulnerable, so the function needs to be modified.
>>
>>
>> Reported-by: syzbot+393d0ef63475d9bb1f16@syzkaller.appspotmail.com
>
> Improve the commit message to explain the problem more clearly.
Esp. I would like to see the stack trace leading to the problem (be it
generated or investigated).
thanks,
--
js
suse labs
next prev parent reply other threads:[~2024-04-22 6:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 2:34 [syzbot] [ppp?] possible deadlock in ppp_asynctty_receive (2) syzbot
2024-04-19 18:12 ` [PATCH net,v2] net: ppp: Fix deadlock caused by unsafe-irq lock in ap_get() Jeongjun Park
2024-04-19 18:38 ` [PATCH net,v3] " Jeongjun Park
2024-04-20 0:31 ` Jakub Kicinski
2024-04-22 6:39 ` Jiri Slaby [this message]
2024-04-22 7:18 ` Jeongjun Park
2024-04-22 7:29 ` Jiri Slaby
2024-04-22 8:58 ` Jeongjun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0032f249-7787-4875-a782-0847c04d5c9c@kernel.org \
--to=jirislaby@kernel.org \
--cc=aha310510@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+393d0ef63475d9bb1f16@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).