From: Allen Pais <allen.cryptic@gmail.com>
To: m.grzeschik@pengutronix.de, davem@davemloft.net,
paulus@samba.org, oliver@neukum.org, woojung.huh@microchip.com,
petkan@nucleusys.com
Cc: keescook@chromium.org, netdev@vger.kernel.org,
linux-ppp@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, Allen Pais <allen.lkml@gmail.com>,
Romain Perier <romain.perier@gmail.com>
Subject: [PATCH 4/9] net: hso: convert tasklets to use new tasklet_setup() API
Date: Mon, 17 Aug 2020 08:58:09 +0000 [thread overview]
Message-ID: <20200817084614.24263-8-allen.cryptic@gmail.com> (raw)
In-Reply-To: <20200817084614.24263-1-allen.cryptic@gmail.com>
From: Allen Pais <allen.lkml@gmail.com>
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/net/usb/hso.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 2bb28db89432..56b3b6395831 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -1213,9 +1213,10 @@ static void hso_std_serial_read_bulk_callback(struct urb *urb)
* This needs to be a tasklet otherwise we will
* end up recursively calling this function.
*/
-static void hso_unthrottle_tasklet(unsigned long data)
+static void hso_unthrottle_tasklet(struct tasklet_struct *t)
{
- struct hso_serial *serial = (struct hso_serial *)data;
+ struct hso_serial *serial = from_tasklet(serial, t,
+ unthrottle_tasklet);
unsigned long flags;
spin_lock_irqsave(&serial->serial_lock, flags);
@@ -1264,9 +1265,8 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp)
serial->rx_state = RX_IDLE;
/* Force default termio settings */
_hso_serial_set_termios(tty, NULL);
- tasklet_init(&serial->unthrottle_tasklet,
- hso_unthrottle_tasklet,
- (unsigned long)serial);
+ tasklet_setup(&serial->unthrottle_tasklet,
+ hso_unthrottle_tasklet);
result = hso_start_serial_device(serial->parent, GFP_KERNEL);
if (result) {
hso_stop_serial_device(serial->parent);
--
2.17.1
next prev parent reply other threads:[~2020-08-17 8:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 8:58 [PATCH 0/8] drivers: net: convert tasklets to use new tasklet_setup() Allen Pais
2020-08-17 8:58 ` [PATCH 1/2] net: arcnet: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-17 8:58 ` [PATCH 1/9] net: ifb: " Allen Pais
2020-08-17 8:58 ` [PATCH] net: mvpp2: Prepare to use the new tasklet API Allen Pais
2020-08-17 8:58 ` [PATCH 2/2] net: caif: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-17 8:58 ` [PATCH 2/9] net: ppp: " Allen Pais
2020-08-17 8:58 ` [PATCH 3/9] net: cdc_ncm: " Allen Pais
2020-08-17 8:58 ` Allen Pais [this message]
2020-08-17 8:58 ` [PATCH 5/9] net: lan78xx: " Allen Pais
2020-08-17 8:58 ` [PATCH 6/9] net: pegasus: " Allen Pais
2020-08-17 8:58 ` [PATCH 7/9] net: r8152: " Allen Pais
2020-08-17 8:58 ` [PATCH 8/9] net: rtl8150: " Allen Pais
2020-08-17 8:58 ` [PATCH 9/9] net: usbnet: " Allen Pais
2020-09-11 5:57 ` [PATCH 0/8] drivers: net: convert tasklets to use new tasklet_setup() Allen
2020-09-11 20:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817084614.24263-8-allen.cryptic@gmail.com \
--to=allen.cryptic@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=paulus@samba.org \
--cc=petkan@nucleusys.com \
--cc=romain.perier@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).