From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 133C7C11F68 for ; Sat, 10 Jul 2021 23:49:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC6A3610A2 for ; Sat, 10 Jul 2021 23:49:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232000AbhGJXwP (ORCPT ); Sat, 10 Jul 2021 19:52:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:38870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232066AbhGJXwJ (ORCPT ); Sat, 10 Jul 2021 19:52:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A0348610A2; Sat, 10 Jul 2021 23:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625960963; bh=k0I2YMG1tLQRkljlc3E6ElPwC47Y6jvVe6lV/XMLR60=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uYf5OoOysNkzIuSpyoyud7szg85pfv2vn9kPm4sYr/0Joz9NJkwce9nMm/AgtvVBO DJ8YhCr3eMrUrY17/gqt+zMn7+6YUJXm4CyO4S6a1Cnk1f9ehk9/HTG9d8dPTJiNrn 6H65kKRRMH2tQ4Ysd+aCV4pCbY1/F0gUDyT+RyGtBD+U58skrdByZp3n2a8o3Um4GZ 4O80OFHvkzFhNQUHiSwYcrIAv+Hkq49jIbF2aezyndihvJv3FHh7ZDiCznr9uqMUsm 8nZCYKoYnIAhp71LbAvYXkOI9HYLAx9K9wHtbVQTCUyrumnePBzzEH7MYkH5iCHddD olF5AASRyEQgg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Thierry Reding , Sasha Levin , linux-pwm@vger.kernel.org Subject: [PATCH AUTOSEL 5.12 04/43] pwm: spear: Don't modify HW state in .remove callback Date: Sat, 10 Jul 2021 19:48:36 -0400 Message-Id: <20210710234915.3220342-4-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710234915.3220342-1-sashal@kernel.org> References: <20210710234915.3220342-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org From: Uwe Kleine-König [ Upstream commit b601a18f12383001e7a8da238de7ca1559ebc450 ] A consumer is expected to disable a PWM before calling pwm_put(). And if they didn't there is hopefully a good reason (or the consumer needs fixing). Also if disabling an enabled PWM was the right thing to do, this should better be done in the framework instead of in each low level driver. So drop the hardware modification from the .remove() callback. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/pwm/pwm-spear.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c index f63b54aae1b4..7467e03d2fb5 100644 --- a/drivers/pwm/pwm-spear.c +++ b/drivers/pwm/pwm-spear.c @@ -229,10 +229,6 @@ static int spear_pwm_probe(struct platform_device *pdev) static int spear_pwm_remove(struct platform_device *pdev) { struct spear_pwm_chip *pc = platform_get_drvdata(pdev); - int i; - - for (i = 0; i < NUM_PWM; i++) - pwm_disable(&pc->chip.pwms[i]); /* clk was prepared in probe, hence unprepare it here */ clk_unprepare(pc->clk); -- 2.30.2