From: Rob Herring <robh@kernel.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
p.zabel@pengutronix.de, linux-pwm@vger.kernel.org,
kernel@collabora.com, chunkuang.hu@kernel.org,
linux-phy@lists.infradead.org, ck.hu@mediatek.com,
jitao.shi@mediatek.com, houlong.wei@mediatek.com,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
vkoul@kernel.org, chunfeng.yun@mediatek.com, daniel@ffwll.ch,
linux-mediatek@lists.infradead.org, xinlei.lee@mediatek.com,
airlied@gmail.com, u.kleine-koenig@pengutronix.de,
linux-arm-kernel@lists.infradead.org,
krzysztof.kozlowski+dt@linaro.org, kishon@kernel.org,
~postmarketos/upstreaming@lists.sr.ht, thierry.reding@gmail.com,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
jassisinghbrar@gmail.com
Subject: Re: [PATCH 01/27] dt-bindings: pwm: Add compatible for MediaTek MT6795
Date: Mon, 17 Apr 2023 19:58:30 -0500 [thread overview]
Message-ID: <20230418005830.GA3802030-robh@kernel.org> (raw)
In-Reply-To: <5c0bc1f2-5917-ab84-8b0b-f2adc48f8be7@gmail.com>
On Thu, Apr 13, 2023 at 10:52:28AM +0200, Matthias Brugger wrote:
>
>
> On 12/04/2023 23:03, Rob Herring wrote:
> >
> > On Wed, 12 Apr 2023 13:27:13 +0200, AngeloGioacchino Del Regno wrote:
> > > Add a compatible string for MediaTek Helio X10 MT6795's display PWM
> > > block: this is the same as MT8173.
> > >
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > > ---
> > > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
>
> These are not new warnings. I think we should address them in a different
> patch. In my opinion it shouldn't block this patch. In the end it only add
> as compatible here.
I disagree if it's the schema that needs fixing. From the looks of
it, I'd say it's probably at least some schema fixes needed.
>
> Regards,
> Matthias
>
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412112739.160376-2-angelogioacchino.delregno@collabora.com
> >
> >
> > pwm@1100e000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
Are you saying the MT6795 has no power-domains?
> > arch/arm64/boot/dts/mediatek/mt8183-evb.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb
> > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb
> >
> > pwm@1400a000: compatible: 'oneOf' conditional failed, one must be fixed:
> > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb
> > arch/arm/boot/dts/mt7623n-rfb-emmc.dtb
> >
> > pwm@1401e000: compatible: 'oneOf' conditional failed, one must be fixed:
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dtb
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb
> > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb
> >
> > pwm@1401f000: compatible: 'oneOf' conditional failed, one must be fixed:
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dtb
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb
> > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb
The commit message says the MT6795 is the same as the MT8173. Which is
wrong here, the dtb or the schema?
Rob
next prev parent reply other threads:[~2023-04-18 0:58 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 11:27 [PATCH 00/27] MediaTek Helio X10 - Mailbox, Display, MMC/SD/SDIO AngeloGioacchino Del Regno
2023-04-12 11:27 ` [PATCH 01/27] dt-bindings: pwm: Add compatible for MediaTek MT6795 AngeloGioacchino Del Regno
2023-04-12 12:30 ` Matthias Brugger
2023-04-12 21:03 ` Rob Herring
2023-04-13 8:52 ` Matthias Brugger
2023-04-13 9:28 ` AngeloGioacchino Del Regno
2023-04-18 0:58 ` Rob Herring [this message]
2023-04-14 5:43 ` Uwe Kleine-König
2023-04-18 11:56 ` Matthias Brugger
2023-04-14 8:21 ` Krzysztof Kozlowski
2023-04-14 8:30 ` Uwe Kleine-König
2023-04-14 8:34 ` Krzysztof Kozlowski
2023-04-14 10:25 ` AngeloGioacchino Del Regno
2023-04-14 10:31 ` Krzysztof Kozlowski
2023-04-14 10:31 ` Krzysztof Kozlowski
2023-05-29 13:51 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 02/27] dt-bindings: phy: mediatek,dsi-phy: Add compatible for MT6795 Helio X10 AngeloGioacchino Del Regno
2023-04-12 12:34 ` Matthias Brugger
2023-04-12 12:59 ` Alexandre Mergnat
2023-04-12 13:03 ` AngeloGioacchino Del Regno
2023-04-12 13:12 ` Alexandre Mergnat
2023-04-12 13:17 ` AngeloGioacchino Del Regno
2023-04-13 8:58 ` Matthias Brugger
2023-04-14 8:22 ` Krzysztof Kozlowski
2023-05-29 14:05 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 03/27] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT6795 AngeloGioacchino Del Regno
2023-04-12 12:35 ` Matthias Brugger
2023-04-14 8:23 ` Krzysztof Kozlowski
2023-04-12 13:13 ` Alexandre Mergnat
2023-04-12 21:03 ` Rob Herring
2023-04-14 8:23 ` Krzysztof Kozlowski
2023-05-29 14:07 ` Matthias Brugger
2023-06-13 0:12 ` Chun-Kuang Hu
2023-04-12 11:27 ` [PATCH 04/27] dt-bindings: display: mediatek: aal: " AngeloGioacchino Del Regno
2023-04-12 12:35 ` Matthias Brugger
2023-04-12 13:03 ` Alexandre Mergnat
2023-04-14 8:24 ` Krzysztof Kozlowski
2023-04-12 11:27 ` [PATCH 05/27] dt-bindings: display: mediatek: dsi: " AngeloGioacchino Del Regno
2023-04-12 12:36 ` Matthias Brugger
2023-04-12 13:21 ` AngeloGioacchino Del Regno
2023-04-12 21:03 ` Rob Herring
2023-04-14 8:24 ` Krzysztof Kozlowski
2023-04-12 11:27 ` [PATCH 06/27] dt-bindings: display: mediatek: ovl: " AngeloGioacchino Del Regno
2023-04-12 21:03 ` Rob Herring
2023-04-14 8:24 ` Krzysztof Kozlowski
2023-04-12 11:27 ` [PATCH 07/27] dt-bindings: display: mediatek: rdma: " AngeloGioacchino Del Regno
2023-04-12 21:03 ` Rob Herring
2023-04-14 8:26 ` Krzysztof Kozlowski
2023-04-12 11:27 ` [PATCH 08/27] dt-bindings: display: mediatek: wdma: " AngeloGioacchino Del Regno
2023-04-12 12:36 ` Matthias Brugger
2023-04-14 8:26 ` Krzysztof Kozlowski
2023-04-12 11:27 ` [PATCH 09/27] dt-bindings: display: mediatek: color: " AngeloGioacchino Del Regno
2023-04-12 12:37 ` Matthias Brugger
2023-04-12 21:03 ` Rob Herring
2023-04-14 8:26 ` Krzysztof Kozlowski
2023-04-12 11:27 ` [PATCH 10/27] dt-bindings: display: mediatek: gamma: " AngeloGioacchino Del Regno
2023-04-14 8:27 ` Krzysztof Kozlowski
2023-04-12 11:27 ` [PATCH 11/27] dt-bindings: display: mediatek: merge: " AngeloGioacchino Del Regno
2023-04-12 12:37 ` Matthias Brugger
2023-04-14 8:33 ` Krzysztof Kozlowski
2023-04-12 11:27 ` [PATCH 12/27] dt-bindings: display: mediatek: split: " AngeloGioacchino Del Regno
2023-04-12 12:37 ` Matthias Brugger
2023-04-14 8:34 ` Krzysztof Kozlowski
2023-04-12 11:27 ` [PATCH 13/27] dt-bindings: display: mediatek: ufoe: " AngeloGioacchino Del Regno
2023-04-12 12:38 ` Matthias Brugger
2023-04-12 21:03 ` Rob Herring
2023-04-14 8:44 ` Krzysztof Kozlowski
2023-04-12 11:27 ` [PATCH 14/27] dt-bindings: display: mediatek: od: " AngeloGioacchino Del Regno
2023-04-12 12:38 ` Matthias Brugger
2023-04-12 21:03 ` Rob Herring
2023-04-14 8:45 ` Krzysztof Kozlowski
2023-04-12 11:27 ` [PATCH 15/27] dt-bindings: mailbox: mediatek,gce-mailbox: Add support for MT6795 AngeloGioacchino Del Regno
2023-04-12 12:38 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 16/27] arm64: dts: mediatek: mt6795: Add support for the CMDQ/GCE mailbox AngeloGioacchino Del Regno
2023-05-29 13:54 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 17/27] arm64: dts: mediatek: mt6795: Add MMSYS node for multimedia clocks AngeloGioacchino Del Regno
2023-05-29 13:55 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 18/27] arm64: dts: mediatek: mt6795: Add support for IOMMU and LARBs AngeloGioacchino Del Regno
2023-05-29 13:56 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 19/27] arm64: dts: mediatek: mt6795: Add support for display blocks and DPI/DSI AngeloGioacchino Del Regno
2023-04-12 11:27 ` [PATCH 20/27] arm64: dts: mediatek: mt6795: Add tertiary PWM node AngeloGioacchino Del Regno
2023-04-12 12:43 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 21/27] arm64: dts: mediatek: mt6795: Add PMIC Wrapper node AngeloGioacchino Del Regno
2023-05-29 13:57 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 22/27] arm64: dts: mediatek: mt6795: Copyright header additions AngeloGioacchino Del Regno
2023-04-12 12:41 ` Matthias Brugger
2023-04-12 13:23 ` AngeloGioacchino Del Regno
2023-04-14 8:46 ` Krzysztof Kozlowski
2023-04-14 10:28 ` AngeloGioacchino Del Regno
2023-04-12 11:27 ` [PATCH 23/27] arm64: dts: mediatek: Add MT6331 PMIC devicetree AngeloGioacchino Del Regno
2023-05-29 13:59 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 24/27] arm64: dts: mediatek: mt6795-xperia-m5: Add MT6331 Combo PMIC AngeloGioacchino Del Regno
2023-05-29 14:00 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 25/27] arm64: dts: mediatek: mt6795-xperia-m5: Add eMMC, MicroSD slot, SDIO AngeloGioacchino Del Regno
2023-05-29 14:01 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 26/27] arm64: dts: mediatek: mt6795-xperia-m5: Add Bosch BMA255 Accelerometer AngeloGioacchino Del Regno
2023-04-12 12:44 ` Matthias Brugger
2023-04-12 11:27 ` [PATCH 27/27] arm64: dts: mediatek: mt6795-xperia-m5: Add Bosch BMM050 Magnetometer AngeloGioacchino Del Regno
2023-04-12 12:44 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418005830.GA3802030-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=houlong.wei@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=jitao.shi@mediatek.com \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=phone-devel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
--cc=xinlei.lee@mediatek.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).