From: Roy Im <roy.im.opensource@diasemi.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Roy Im <roy.im.opensource@diasemi.com>,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Brian Masney <masneyb@onstation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>, Luca Weiss <luca@z3ntu.xyz>,
Maximilian Luz <luzmaximilian@gmail.com>,
Pascal PAILLET-LME <p.paillet@st.com>,
Rob Herring <robh@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Support Opensource <Support.Opensource@diasemi.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Subject: RE: [PATCH V17 3/3] Input: new da7280 haptic driver
Date: Fri, 24 Jul 2020 05:47:04 +0000 [thread overview]
Message-ID: <DB8PR10MB343624BF003338E8B34439AC85770@DB8PR10MB3436.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <f549102d-4e69-c903-1672-f50bdb7994a3@infradead.org>
Friday, July 24, 2020 11:57 AM, Randy Dunlap wrote
> On 7/23/20 6:54 PM, Roy Im wrote:
> > On Fri, July 24, 2020 5:51 AM, Randy Dunlap wrote
> >> On 7/23/20 8:01 AM, Roy Im wrote:
> >>> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> >>> index 362e8a0..06dc5a3 100644
> >>> --- a/drivers/input/misc/Kconfig
> >>> +++ b/drivers/input/misc/Kconfig
> >>> @@ -869,4 +869,17 @@ config INPUT_STPMIC1_ONKEY
> >>> To compile this driver as a module, choose M here: the
> >>> module will be called stpmic1_onkey.
> >>>
> >>> +config INPUT_DA7280_HAPTICS
> >>> + tristate "Dialog Semiconductor DA7280 haptics support"
> >>> + depends on INPUT && I2C
> >>> + select INPUT_FF_MEMLESS
> >>> + select REGMAP_I2C
> >>> + help
> >>> + Say Y to enable support for the Dialog DA7280 haptics driver.
> >>> + The haptics can be controlled by I2C communication,
> >>> + or by PWM input, or by GPI.
> >>
> >> Is that GPIO.
> >> ?
> > The Haptics can be working by GPI(if see from the haptic device), but from the Host it is GPO. Do you think the GPIO is
> correct?
>
> To me it needs to represent what services/interfaces/facilities are used by this driver that are provided by the Linux kernel.
> If it uses Linux GPIO services, then it should say GPIO -- although I don't see it using any Linux GPIO services.
OK, let me change to GPIO.
>
> >>
> >> Can the haptics be controlled only by PWM or only by GPI(O)?
> >>
> >> Just curious: why is I2C required to build the driver if a user is only controlling the device by PWM or GPI?
> >
> > I2C is required to control registers and it can be triggered by I2C or PWM or GPI(controlled by host outside this driver),
> so PWM and GPI are optional.
> > With your comments, I think it's better to remove below lines(//remove) to avoid confusion and add PWM as below if
> you agree.
> > // remove
> > The haptics can be controlled by I2C communication,
> > or by PWM input, or by GPI.
> > // update, adding || PWM
> > depends on (INPUT && I2C) || PWM
>
> Since <linux/pwm.h> provides stubs for when CONFIG_PWM is not enabled, it appears that "depends on PWM" is not
> required.
>
> I'll leave it up to you. I was just trying to understand better.
> It may be that no changes are needed.
OK, thanks for your comments. To be clearer, I would like to update as below if you agree
depends on INPUT && I2C
...
The haptics can be controlled by PWM or GPIO
with I2C communication.
>
>
> thanks.
> --
> ~Randy
Kind regards,
Roy
next prev parent reply other threads:[~2020-07-24 5:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1595516501.git.Roy.Im@diasemi.com>
2020-07-23 15:01 ` [PATCH V17 3/3] Input: new da7280 haptic driver Roy Im
2020-07-23 20:50 ` Randy Dunlap
2020-07-24 1:54 ` Roy Im
2020-07-24 2:56 ` Randy Dunlap
2020-07-24 5:47 ` Roy Im [this message]
2020-07-24 5:47 ` Roy Im
2020-07-24 5:48 ` Randy Dunlap
2020-07-24 5:48 ` Randy Dunlap
2020-07-23 20:55 ` Randy Dunlap
2020-07-24 2:06 ` Roy Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR10MB343624BF003338E8B34439AC85770@DB8PR10MB3436.EURPRD10.PROD.OUTLOOK.COM \
--to=roy.im.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=bgolaszewski@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=luzmaximilian@gmail.com \
--cc=masneyb@onstation.org \
--cc=p.paillet@st.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=sameo@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).