From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Walle Subject: Re: [PATCH v5 13/13] arm64: dts: freescale: sl28: enable fan support Date: Wed, 08 Jul 2020 09:56:13 +0200 Message-ID: References: <20200706175353.16404-1-michael@walle.cc> <20200706175353.16404-14-michael@walle.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LINUXWATCHDOG , Linux ARM , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner List-Id: linux-pwm@vger.kernel.org Hi Linus, Am 2020-07-08 09:39, schrieb Linus Walleij: > just a drive-by-comment: > > On Mon, Jul 6, 2020 at 7:57 PM Michael Walle wrote: > >> Add a pwm-fan mapped to the PWM channel 0 which is connected to the >> fan connector of the carrier. >> >> Signed-off-by: Michael Walle > > If you have a cooling device like this, do you also have a temperature > sensor? In that case it makes sense to add a thermal zone and a > policy, such as I did for a device in > 6e97f0aaca4ca778905dd1dc667cbf379f4cae15 Yep, the CPU and DDR controller have temperatur sensors and there are already thermal zones for them. We have the fan linked to the policies in our vendor DTS overlay. For now I didn't want to include that here, mainly because there are no labels in the fsl-ls1028a.dtsi for the thermal zone/cooling maps/trips. But this is still on my TODO, when this series finally make it into the kernel ;) -michael