From: Zhao Heming <heming.zhao@suse.com>
To: linux-raid@vger.kernel.org, jes@trained-monkey.org
Cc: Zhao Heming <heming.zhao@suse.com>,
lidong.zhong@suse.com, xni@redhat.com
Subject: [PATCH] super1: fix Floating point exception
Date: Sat, 30 Jan 2021 17:49:54 +0800 [thread overview]
Message-ID: <1612000194-6015-1-git-send-email-heming.zhao@suse.com> (raw)
write_bitmap1 didn't check return value of locate_bitmap1, which will
operate bitmap area under invalid bitmap info.
mdadm core dumped when doing below steps:
```
node1 # mdadm -C /dev/md0 -b none -e 1.2 -n 2 -l mirror /dev/sda /dev/sdb
node1 # mdadm -Ss
node1 # mdadm -A -U home-cluster --home-cluster=abc /dev/md0 /dev/sda /dev/sdb
Floating point exception (core dumped)
```
Signed-off-by: Zhao Heming <heming.zhao@suse.com>
---
super1.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/super1.c b/super1.c
index 8b0d6ff..19fe6f5 100644
--- a/super1.c
+++ b/super1.c
@@ -2683,7 +2683,10 @@ static int write_bitmap1(struct supertype *st, int fd, enum bitmap_update update
init_afd(&afd, fd);
- locate_bitmap1(st, fd, 0);
+ if (locate_bitmap1(st, fd, 0) < 0) {
+ pr_err("Error: Invalid bitmap\n");
+ return -EINVAL;
+ }
if (posix_memalign(&buf, 4096, 4096))
return -ENOMEM;
--
2.29.2
next reply other threads:[~2021-01-30 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 9:49 Zhao Heming [this message]
2021-03-02 8:34 ` resend: [PATCH mdadm] super1: fix Floating point exception heming.zhao
2021-03-03 14:30 ` [PATCH] " Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1612000194-6015-1-git-send-email-heming.zhao@suse.com \
--to=heming.zhao@suse.com \
--cc=jes@trained-monkey.org \
--cc=lidong.zhong@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).