From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D04C4727D for ; Tue, 22 Sep 2020 08:45:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CA8F2085B for ; Tue, 22 Sep 2020 08:45:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726565AbgIVIpU (ORCPT ); Tue, 22 Sep 2020 04:45:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:52296 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726366AbgIVIpU (ORCPT ); Tue, 22 Sep 2020 04:45:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B80B1AEEF; Tue, 22 Sep 2020 08:45:54 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id ED14B1E12E3; Tue, 22 Sep 2020 10:45:17 +0200 (CEST) Date: Tue, 22 Sep 2020 10:45:17 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Song Liu , Hans de Goede , Coly Li , Richard Weinberger , Minchan Kim , Johannes Thumshirn , Justin Sanders , linux-mtd@lists.infradead.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: [PATCH 04/13] aoe: set an optimal I/O size Message-ID: <20200922084517.GB16464@quack2.suse.cz> References: <20200921080734.452759-1-hch@lst.de> <20200921080734.452759-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921080734.452759-5-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On Mon 21-09-20 10:07:25, Christoph Hellwig wrote: > aoe forces a larger readahead size, but any reason to do larger I/O > is not limited to readahead. Also set the optimal I/O size, and > remove the local constants in favor of just using SZ_2G. > > Signed-off-by: Christoph Hellwig Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/block/aoe/aoeblk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c > index 5ca7216e9e01f3..d8cfc233e64b93 100644 > --- a/drivers/block/aoe/aoeblk.c > +++ b/drivers/block/aoe/aoeblk.c > @@ -347,7 +347,6 @@ aoeblk_gdalloc(void *vp) > mempool_t *mp; > struct request_queue *q; > struct blk_mq_tag_set *set; > - enum { KB = 1024, MB = KB * KB, READ_AHEAD = 2 * MB, }; > ulong flags; > int late = 0; > int err; > @@ -407,7 +406,8 @@ aoeblk_gdalloc(void *vp) > WARN_ON(d->gd); > WARN_ON(d->flags & DEVFL_UP); > blk_queue_max_hw_sectors(q, BLK_DEF_MAX_SECTORS); > - q->backing_dev_info->ra_pages = READ_AHEAD / PAGE_SIZE; > + q->backing_dev_info->ra_pages = SZ_2M / PAGE_SIZE; > + blk_queue_io_opt(q, SZ_2M); > d->bufpool = mp; > d->blkq = gd->queue = q; > q->queuedata = d; > -- > 2.28.0 > -- Jan Kara SUSE Labs, CR