From: Song Liu <song@kernel.org>
To: "heming.zhao@suse.com" <heming.zhao@suse.com>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH 1/2] [md/bitmap] md_bitmap_read_sb use wrong bitmap blocks
Date: Mon, 5 Oct 2020 00:44:00 -0700 [thread overview]
Message-ID: <CAPhsuW6sWyJ60iEtY2yuFbKYwC6DN-ZaC2rOwo2OykWrHYidsw@mail.gmail.com> (raw)
In-Reply-To: <51da8823-aed1-dc45-d14e-3b30c8f88aa0@suse.com>
On Sat, Oct 3, 2020 at 9:26 AM heming.zhao@suse.com
<heming.zhao@suse.com> wrote:
>
> very sorry for my mistake.
>
> the patch should be change from:
> ```
> - sector_div(bm_blocks,
> + DIV_ROUND_UP_SECTOR_T(bm_blocks,
> bitmap->mddev->bitmap_info.chunksize >> 9);
> ```
>
> to
> ```
> - sector_div(bm_blocks,
> - bitmap->mddev->bitmap_info.chunksize >> 9);
> + bm_blocks = DIV_ROUND_UP_SECTOR_T(bm_blocks,
> + (bitmap->mddev->bitmap_info.chunksize >> 9));
> ```
>
> If my patch would be accepted, I will send v2 patch including above lines.
Please send v2 of the patch. Please also CC Guoqing in v2.
Thanks,
Song
prev parent reply other threads:[~2020-10-05 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 16:11 [PATCH 1/2] [md/bitmap] md_bitmap_read_sb use wrong bitmap blocks Zhao Heming
2020-10-03 16:11 ` [PATCH 2/2] [md/bitmap] md_bitmap_get_counter return wrong blocks in some cases Zhao Heming
2020-10-03 16:26 ` [PATCH 1/2] [md/bitmap] md_bitmap_read_sb use wrong bitmap blocks heming.zhao
2020-10-05 7:44 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPhsuW6sWyJ60iEtY2yuFbKYwC6DN-ZaC2rOwo2OykWrHYidsw@mail.gmail.com \
--to=song@kernel.org \
--cc=heming.zhao@suse.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).