linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Bruce Fields <bfields@fieldses.org>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 00/29] Possible NFSD patches for v5.8
Date: Tue, 19 May 2020 19:32:37 -0400	[thread overview]
Message-ID: <000ED881-6724-46EE-894E-57CD6DE10A15@oracle.com> (raw)
In-Reply-To: <470B6839-FBC6-49BA-B633-DD49D271FD42@oracle.com>



> On May 19, 2020, at 6:25 PM, Chuck Lever <chuck.lever@oracle.com> wrote:
> 
> Hi Bruce-
> 
>> On May 19, 2020, at 5:29 PM, Bruce Fields <bfields@fieldses.org> wrote:
>> 
>> On Tue, May 19, 2020 at 12:14:22PM -0400, Chuck Lever wrote:
>>> 
>>> 
>>>> On May 19, 2020, at 12:11 PM, J. Bruce Fields <bfields@fieldses.org> wrote:
>>>> 
>>>> I'm getting a repeatable timeout failure on python 4.0 test WRT15.  In
>>>> pynfs, run: 
>>>> 
>>>> 	./nfs4.0/testserver.py server:/export/path --rundeps --maketree WRT15
>>>> 
>>>> Looks like it sends WRITE+GETATTR(FATTR4_SIZE) compounds with write
>>>> offset 0 and write length taking on every value from 0 to 8192.
>>>> 
>>>> Probably an xdr decoding bug of some kind?
>>> 
>>> My first thought is to bisect, but I don't see a particular change in my
>>> v5.8 series that would plausibly introduce this class of problem.
>> 
>> It's SUNRPC: Refactor svc_recvfrom().
>> 
>> That was just from a quick automated bisect.  I haven't tried to figure
>> out where the bug is....
> 
> Your reproducer isn't working for me on EL7.
> 
> [root@manet ~]# yum install krb5-devel python3-devel swig python3-gssapi python3-ply
> Loaded plugins: ulninfo
> Package krb5-devel-1.15.1-46.el7.x86_64 already installed and latest version
> Package python3-devel-3.6.8-13.0.1.el7.x86_64 already installed and latest version
> Package swig-2.0.10-5.el7.x86_64 already installed and latest version
> No package python3-gssapi available.
> No package python3-ply available.
> Nothing to do
> [root@manet ~]# logout
> [cel@manet pynfs]$ ./nfs4.0/testserver.py server:/export/path --rundeps --maketree WRT15
> Traceback (most recent call last):
>  File "./nfs4.0/testserver.py", line 388, in <module>
>    main()
>  File "./nfs4.0/testserver.py", line 242, in main
>    opt.machinename = os.fsencode(opt.machinename)
> AttributeError: 'module' object has no attribute 'fsencode'
> [cel@manet pynfs]$

I've reproduced your original test failure. I can take a closer look
tomorrow.

Looks like python3 is now a requirement for pynfs, despite the comments
and code in nfs4.0/testserver.py.

Also, the README should explain that the server under test has to permit
access from insecure source ports (this still might not be the default
for some NFS servers).


--
Chuck Lever




  reply	other threads:[~2020-05-19 23:34 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 21:22 [PATCH v2 00/29] Possible NFSD patches for v5.8 Chuck Lever
2020-05-12 21:22 ` [PATCH v2 01/29] SUNRPC: Move xpt_mutex into socket xpo_sendto methods Chuck Lever
2020-05-12 21:22 ` [PATCH v2 02/29] svcrdma: Clean up the tracing for rw_ctx_init errors Chuck Lever
2020-05-12 21:22 ` [PATCH v2 03/29] svcrdma: Clean up handling of get_rw_ctx errors Chuck Lever
2020-05-12 21:22 ` [PATCH v2 04/29] svcrdma: Trace page overruns when constructing RDMA Reads Chuck Lever
2020-05-12 21:22 ` [PATCH v2 05/29] svcrdma: trace undersized Write chunks Chuck Lever
2020-05-12 21:22 ` [PATCH v2 06/29] svcrdma: Fix backchannel return code Chuck Lever
2020-05-12 21:22 ` [PATCH v2 07/29] svcrdma: Remove backchannel dprintk call sites Chuck Lever
2020-05-12 21:22 ` [PATCH v2 08/29] svcrdma: Rename tracepoints that record header decoding errors Chuck Lever
2020-05-12 21:22 ` [PATCH v2 09/29] svcrdma: Remove the SVCRDMA_DEBUG macro Chuck Lever
2020-05-12 21:22 ` [PATCH v2 10/29] svcrdma: Displayed remote IP address should match stored address Chuck Lever
2020-05-12 21:23 ` [PATCH v2 11/29] svcrdma: Add tracepoints to report ->xpo_accept failures Chuck Lever
2020-05-12 21:23 ` [PATCH v2 12/29] SUNRPC: Remove kernel memory address from svc_xprt tracepoints Chuck Lever
2020-05-12 21:23 ` [PATCH v2 13/29] SUNRPC: Tracepoint to record errors in svc_xpo_create() Chuck Lever
2020-05-12 21:23 ` [PATCH v2 14/29] SUNRPC: Trace a few more generic svc_xprt events Chuck Lever
2020-05-12 21:23 ` [PATCH v2 15/29] SUNRPC: Remove "#include <trace/events/skb.h>" Chuck Lever
2020-05-12 21:23 ` [PATCH v2 16/29] SUNRPC: Add more svcsock tracepoints Chuck Lever
2020-05-12 21:23 ` [PATCH v2 17/29] SUNRPC: Replace dprintk call sites in TCP state change callouts Chuck Lever
2020-05-12 21:23 ` [PATCH v2 18/29] SUNRPC: Trace server-side rpcbind registration events Chuck Lever
2020-05-12 21:23 ` [PATCH v2 19/29] SUNRPC: Rename svc_sock::sk_reclen Chuck Lever
2020-05-12 21:23 ` [PATCH v2 20/29] SUNRPC: Restructure svc_tcp_recv_record() Chuck Lever
2020-05-12 21:23 ` [PATCH v2 21/29] SUNRPC: Refactor svc_recvfrom() Chuck Lever
2020-05-12 21:24 ` [PATCH v2 22/29] SUNRPC: Restructure svc_udp_recvfrom() Chuck Lever
2020-05-12 21:24 ` [PATCH v2 23/29] SUNRPC: svc_show_status() macro should have enum definitions Chuck Lever
2020-05-12 21:24 ` [PATCH v2 24/29] NFSD: Add tracepoints to NFSD's duplicate reply cache Chuck Lever
2020-05-12 21:24 ` [PATCH v2 25/29] NFSD: Add tracepoints to the NFSD state management code Chuck Lever
2020-05-12 21:24 ` [PATCH v2 26/29] NFSD: Add tracepoints for monitoring NFSD callbacks Chuck Lever
2020-05-12 21:24 ` [PATCH v2 27/29] SUNRPC: Clean up request deferral tracepoints Chuck Lever
2020-05-12 21:24 ` [PATCH v2 28/29] NFSD: Squash an annoying compiler warning Chuck Lever
2020-05-12 21:24 ` [PATCH v2 29/29] NFSD: Fix improperly-formatted Doxygen comments Chuck Lever
2020-05-19 16:11 ` [PATCH v2 00/29] Possible NFSD patches for v5.8 J. Bruce Fields
2020-05-19 16:14   ` Chuck Lever
2020-05-19 21:29     ` Bruce Fields
2020-05-19 22:25       ` Chuck Lever
2020-05-19 23:32         ` Chuck Lever [this message]
2020-05-20 16:46           ` Bruce Fields
2020-05-20 16:48             ` Chuck Lever
2020-05-20 17:01               ` Bruce Fields
2020-05-20 17:01             ` Calum Mackay
2020-05-20 17:14               ` Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=000ED881-6724-46EE-894E-57CD6DE10A15@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).