linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Weihang Li <liweihang@huawei.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Weihang Li <liweihang@hisilicon.com>, <dledford@redhat.com>,
	<linux-rdma@vger.kernel.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH for-next] RDMA/hns: Add support for extended atomic
Date: Tue, 14 Jan 2020 09:53:07 +0800	[thread overview]
Message-ID: <05e78494-20fc-b551-9a5b-2eb577206286@huawei.com> (raw)
In-Reply-To: <20200103133907.GB9706@ziepe.ca>



On 2020/1/3 21:39, Jason Gunthorpe wrote:
> On Fri, Jan 03, 2020 at 01:57:22PM +0800, Weihang Li wrote:
> 
>  
>> This patch has no relationship with the userspace one you pointed out.
>> But I have pushed a userspace patch that support extended atomic on hip08,
>> maybe you were asking about the following one:
>>
>> https://github.com/linux-rdma/rdma-core/pull/638
> 
> Right, sorry
>  
>> The kernel part is not needed by the userspace part, they are independent
>> of each other.
>>
>> We made this patch because we noticed that some other providers has also
>> support this feature in kernel, maybe there will be some kernel users in
>> future. I would be grateful if you could give me more suggestions.
> 
> I think we have no kernel users of extended atomics, it is probably an
> mistake that other providers implemented this in the kernel.
> 
> I would advise against making the hns send path more complicated with
> dead code.
> 
> Jason
> 
> 

Hi Jason,

Thanks for your reminder about extended atomic in kernel and sorry for the
delayed response.

We cancel this patch as your suggestion, and will send another one which
the user space extended atomic is dependent on.

Weihang


  reply	other threads:[~2020-01-14  1:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15  1:39 [PATCH for-next] RDMA/hns: Add support for extended atomic Weihang Li
2019-12-10 13:10 ` Weihang Li
2019-12-19 19:07   ` Jason Gunthorpe
2020-01-02 21:03 ` Jason Gunthorpe
2020-01-03  5:57   ` Weihang Li
2020-01-03 13:39     ` Jason Gunthorpe
2020-01-14  1:53       ` Weihang Li [this message]
2020-01-14 13:29         ` Jason Gunthorpe
2020-01-15  1:30           ` Weihang Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05e78494-20fc-b551-9a5b-2eb577206286@huawei.com \
    --to=liweihang@huawei.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=liweihang@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).