From: "Liuyixian (Eason)" <liuyixian@huawei.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: <dledford@redhat.com>, <leon@kernel.org>,
<linux-rdma@vger.kernel.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH v5 for-next 1/2] RDMA/hns: Add the workqueue framework for flush cqe handler
Date: Sat, 11 Jan 2020 17:49:45 +0800 [thread overview]
Message-ID: <0c78d7db-21ce-10bd-8a75-f712d18a1c83@huawei.com> (raw)
In-Reply-To: <20200110152602.GC8765@ziepe.ca>
On 2020/1/10 23:26, Jason Gunthorpe wrote:
> On Sat, Dec 28, 2019 at 11:28:54AM +0800, Yixian Liu wrote:
>> +void init_flush_work(struct hns_roce_dev *hr_dev, struct hns_roce_qp *hr_qp)
>> +{
>> + struct hns_roce_work *flush_work;
>> +
>> + flush_work = kzalloc(sizeof(struct hns_roce_work), GFP_ATOMIC);
>> + if (!flush_work)
>> + return;
>
> You changed it to only queue once, so why do we need the allocation
> now? That was the whole point..
>
> And the other patch shouldn't be manipulating being_pushed without
> some kind of locking
Hi Jason, thanks for your suggestion, I will consider them in next version.
>
> Jason
>
>
next prev parent reply other threads:[~2020-01-11 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 3:28 [PATCH v5 for-next 0/2] RDMA/hns: Add the workqueue framework for flush cqe handler Yixian Liu
2019-12-28 3:28 ` [PATCH v5 for-next 1/2] " Yixian Liu
2020-01-10 15:26 ` Jason Gunthorpe
2020-01-11 9:49 ` Liuyixian (Eason) [this message]
2020-01-13 11:26 ` Liuyixian (Eason)
2020-01-13 14:04 ` Jason Gunthorpe
2020-01-15 9:36 ` Liuyixian (Eason)
2020-01-15 9:39 ` Liuyixian (Eason)
2019-12-28 3:28 ` [PATCH v5 for-next 2/2] RDMA/hns: Delayed flush cqe process with workqueue Yixian Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c78d7db-21ce-10bd-8a75-f712d18a1c83@huawei.com \
--to=liuyixian@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).