From: Jason Gunthorpe <jgg@mellanox.com>
To: Yuval Shaia <yuval.shaia@oracle.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"leon@kernel.org" <leon@kernel.org>,
Moni Shoua <monis@mellanox.com>,
Parav Pandit <parav@mellanox.com>,
Daniel Jurgens <danielj@mellanox.com>,
"kamalheib1@gmail.com" <kamalheib1@gmail.com>,
Mark Zhang <markz@mellanox.com>,
"swise@opengridcomputing.com" <swise@opengridcomputing.com>,
"shamir.rabinovitch@oracle.com" <shamir.rabinovitch@oracle.com>,
"johannes.berg@intel.com" <johannes.berg@intel.com>,
"willy@infradead.org" <willy@infradead.org>,
Michael Guralnik <michaelgur@mellanox.com>,
Mark Bloch <markb@mellanox.com>,
"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
Max Gurtovoy <maxg@mellanox.com>,
Israel Rukshin <israelr@mellanox.com>,
"galpress@amazon.com" <galpress@amazon.com>,
Denis Drozdov <denisd@mellanox.com>,
Yuval Avnery <yuvalav@mellanox.com>,
"dennis.dalessandro@intel.com" <dennis.dalessandro@intel.com>,
"will@kernel.org" <will@kernel.org>,
Erez Alfasi <ereza@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Shamir Rabinovitch <srabinov7@gmail.com>
Subject: Re: [PATCH v1 07/24] IB/uverbs: Add context import lock/unlock helper
Date: Wed, 21 Aug 2019 14:57:59 +0000 [thread overview]
Message-ID: <20190821145754.GC8667@mellanox.com> (raw)
In-Reply-To: <20190821142125.5706-8-yuval.shaia@oracle.com>
On Wed, Aug 21, 2019 at 05:21:08PM +0300, Yuval Shaia wrote:
> From: Shamir Rabinovitch <shamir.rabinovitch@oracle.com>
>
> The lock/unlock helpers will be used in every import verb.
>
> Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@oracle.com>
> Signed-off-by: Shamir Rabinovitch <srabinov7@gmail.com>
> drivers/infiniband/core/uverbs.h | 2 +
> drivers/infiniband/core/uverbs_cmd.c | 73 +++++++++++++++++++++++++++
> drivers/infiniband/core/uverbs_main.c | 1 +
> 3 files changed, 76 insertions(+)
>
> diff --git a/drivers/infiniband/core/uverbs.h b/drivers/infiniband/core/uverbs.h
> index 1e5aeb39f774..cf76336cb460 100644
> +++ b/drivers/infiniband/core/uverbs.h
> @@ -163,6 +163,8 @@ struct ib_uverbs_file {
> struct page *disassociate_page;
>
> struct xarray idr;
> +
> + struct file *filp;
> };
>
> struct ib_uverbs_event {
> diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
> index 4f42f9732dca..21f0a1a986f4 100644
> +++ b/drivers/infiniband/core/uverbs_cmd.c
> @@ -43,6 +43,7 @@
>
> #include <rdma/uverbs_types.h>
> #include <rdma/uverbs_std_types.h>
> +#include <rdma/uverbs_ioctl.h>
> #include "rdma_core.h"
>
> #include "uverbs.h"
> @@ -3791,6 +3792,78 @@ static void uverbs_init_attrs_ufile(struct uverbs_attr_bundle *attrs_bundle,
> };
> }
>
> +/* ib_uverbs_import_lock - Function which gathers code that is
> + * common in the import verbs.
> + *
> + * This function guarntee that both source and destination files are
> + * protected from race with vfs close. The current file is protected
> + * from such race because verb is executed in a system-call context.
> + * The other file is protected by 'fget'. This function also ensures
> + * that ib_uobject identified by the type & handle is locked for read.
> + *
> + * Callers of this helper must also call ib_uverbs_import_unlock
> + * to undo any locking performed by this helper.
> + */
> +static int ib_uverbs_import_lock(struct uverbs_attr_bundle *attrs,
This isn't a lock, it is a get
> + int fd, u16 type, u32 handle,
> + struct ib_uobject **uobj,
> + struct file **filep,
> + struct ib_uverbs_file **ufile)
> +{
> + struct ib_uverbs_file *file = attrs->ufile;
> + struct ib_uverbs_device *dev = file->device;
> + struct uverbs_attr_bundle fd_attrs;
> + struct ib_uverbs_device *fd_dev;
> + int ret = 0;
> +
> + *filep = fget(fd);
> + if (!*filep)
> + return -EINVAL;
> +
> + /* check uverbs ops exist */
> + if ((*filep)->f_op != file->filp->f_op) {
> + ret = -EINVAL;
> + goto file;
> + }
> +
> + *ufile = (*filep)->private_data;
> + fd_dev = (*ufile)->device;
Most likely all of this should be in the ioctl code as part of some
> + /* check that both files belong to same ib_device */
> + if (dev != fd_dev) {
> + ret = -EINVAL;
> + goto file;
> + }
> +
> + uverbs_init_attrs_ufile(&fd_attrs, *ufile);
This makes no sense here
> + *uobj = uobj_get_read(type, handle, &fd_attrs);
> + if (IS_ERR(*uobj)) {
> + ret = -EINVAL;
> + goto file;
> + }
> +
> + /* verify ib_object is shareable */
> + if (!(*uobj)->refcnt) {
> + ret = -EINVAL;
> + goto uobj;
> + }
> +
> + return 0;
> +uobj:
> + uobj_put_read(*uobj);
> +file:
> + fput(*filep);
> + return ret;
> +}
Most likely most of this belongs to the ioctl path as some new input
attr type 'foreign context'
Jason
next prev parent reply other threads:[~2019-08-21 14:58 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 14:21 [PATCH v1 00/24] Shared PD and MR Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 01/24] RDMA/uverbs: uobj_get_obj_read should return the ib_uobject Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 02/24] RDMA/uverbs: Delete the macro uobj_put_obj_read Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 03/24] RDMA/nldev: ib_pd can be pointed by multiple ib_ucontext Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 04/24] IB/{core,hw}: ib_pd should not have ib_uobject pointer Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 05/24] IB/core: ib_uobject need HW object reference count Yuval Shaia
2019-08-21 14:53 ` Jason Gunthorpe
2019-08-27 16:28 ` Yuval Shaia
2019-08-27 18:18 ` Jason Gunthorpe
2019-08-21 14:21 ` [PATCH v1 06/24] IB/uverbs: Helper function to initialize ufile member of uverbs_attr_bundle Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 07/24] IB/uverbs: Add context import lock/unlock helper Yuval Shaia
2019-08-21 14:57 ` Jason Gunthorpe [this message]
2019-08-21 14:21 ` [PATCH v1 08/24] IB/verbs: Prototype of HW object clone callback Yuval Shaia
2019-08-21 14:59 ` Jason Gunthorpe
2019-08-21 14:21 ` [PATCH v1 09/24] IB/core: Install clone ib_pd in device ops Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 10/24] IB/mlx4: Add implementation of clone_pd callback Yuval Shaia
2019-08-21 14:59 ` Jason Gunthorpe
2019-08-21 14:21 ` [PATCH v1 11/24] IB/mlx5: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 12/24] RDMA/rxe: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 13/24] IB/uverbs: Add clone reference counting to ib_pd Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 14/24] IB/uverbs: Add PD import verb Yuval Shaia
2019-08-21 15:00 ` Jason Gunthorpe
2019-08-21 14:21 ` [PATCH v1 15/24] IB/mlx4: Enable import from FD verb Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 16/24] IB/mlx5: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 17/24] RDMA/rxe: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 18/24] IB/core: ib_mr should not have ib_uobject pointer Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 19/24] IB/core: Install clone ib_mr in device ops Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 20/24] IB/mlx4: Add implementation of clone_pd callback Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 21/24] IB/mlx5: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 22/24] RDMA/rxe: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 23/24] IB/uverbs: Add clone reference counting to ib_mr Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 24/24] IB/uverbs: Add MR import verb Yuval Shaia
2019-08-21 14:50 ` [PATCH v1 00/24] Shared PD and MR Jason Gunthorpe
2019-08-22 8:50 ` Yuval Shaia
2019-08-21 23:37 ` Ira Weiny
2019-08-22 8:41 ` Yuval Shaia
2019-08-22 14:15 ` Doug Ledford
2019-08-26 9:35 ` Yuval Shaia
2019-08-22 16:58 ` Ira Weiny
2019-08-22 17:03 ` Jason Gunthorpe
2019-08-22 20:10 ` Weiny, Ira
2019-08-23 11:57 ` Jason Gunthorpe
2019-08-23 21:33 ` Weiny, Ira
2019-08-26 10:58 ` Yuval Shaia
2019-08-26 10:29 ` Yuval Shaia
2019-08-26 12:26 ` Jason Gunthorpe
2019-08-26 9:51 ` Yuval Shaia
2019-08-26 10:04 ` Yuval Shaia
2019-08-26 10:10 ` Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821145754.GC8667@mellanox.com \
--to=jgg@mellanox.com \
--cc=bvanassche@acm.org \
--cc=dan.carpenter@oracle.com \
--cc=danielj@mellanox.com \
--cc=denisd@mellanox.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=ereza@mellanox.com \
--cc=galpress@amazon.com \
--cc=israelr@mellanox.com \
--cc=johannes.berg@intel.com \
--cc=kamalheib1@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markb@mellanox.com \
--cc=markz@mellanox.com \
--cc=maxg@mellanox.com \
--cc=michaelgur@mellanox.com \
--cc=monis@mellanox.com \
--cc=parav@mellanox.com \
--cc=shamir.rabinovitch@oracle.com \
--cc=srabinov7@gmail.com \
--cc=swise@opengridcomputing.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yuval.shaia@oracle.com \
--cc=yuvalav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).