From: Potnuri Bharat Teja <bharat@chelsio.com>
To: Bernard Metzler <bmt@zurich.ibm.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>
Subject: Re: [PATCH v1 rdma-next] RDMA/siw: Relax from kmap_atomic() use in TX path
Date: Mon, 9 Sep 2019 20:24:32 +0530 [thread overview]
Message-ID: <20190909145427.GA12481@chelsio.com> (raw)
In-Reply-To: <20190909132945.30462-1-bmt@zurich.ibm.com>
On Monday, September 09/09/19, 2019 at 18:59:45 +0530, Bernard Metzler wrote:
> Since the transmit path is never executed in an atomic
> context, we do not need kmap_atomic() and can always
> use less demanding kmap().
>
> Signed-off-by: Bernard Metzler <bmt@zurich.ibm.com>
> ---
> drivers/infiniband/sw/siw/siw_qp_tx.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/infiniband/sw/siw/siw_qp_tx.c b/drivers/infiniband/sw/siw/siw_qp_tx.c
> index 8e72f955921d..5d97bba0ce6d 100644
> --- a/drivers/infiniband/sw/siw/siw_qp_tx.c
> +++ b/drivers/infiniband/sw/siw/siw_qp_tx.c
> @@ -76,16 +76,15 @@ static int siw_try_1seg(struct siw_iwarp_tx *c_tx, void *paddr)
> if (unlikely(!p))
> return -EFAULT;
>
> - buffer = kmap_atomic(p);
> + buffer = kmap(p);
>
> if (likely(PAGE_SIZE - off >= bytes)) {
> memcpy(paddr, buffer + off, bytes);
> - kunmap_atomic(buffer);
missing kunmap()
> } else {
> unsigned long part = bytes - (PAGE_SIZE - off);
>
> memcpy(paddr, buffer + off, part);
> - kunmap_atomic(buffer);
> + kunmap(p);
kunmap(buffer)
>
> if (!mem->is_pbl)
> p = siw_get_upage(mem->umem,
> @@ -97,11 +96,10 @@ static int siw_try_1seg(struct siw_iwarp_tx *c_tx, void *paddr)
> if (unlikely(!p))
> return -EFAULT;
>
> - buffer = kmap_atomic(p);
> - memcpy(paddr + part, buffer,
> - bytes - part);
> - kunmap_atomic(buffer);
> + buffer = kmap(p);
> + memcpy(paddr + part, buffer, bytes - part);
> }
> + kunmap(p);
Can this be out of if()? the buffers seem to be different.
> }
> }
> return (int)bytes;
> --
> 2.17.2
>
next prev parent reply other threads:[~2019-09-09 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 13:29 [PATCH v1 rdma-next] RDMA/siw: Relax from kmap_atomic() use in TX path Bernard Metzler
2019-09-09 14:54 ` Potnuri Bharat Teja [this message]
2019-09-10 8:13 ` Bernard Metzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909145427.GA12481@chelsio.com \
--to=bharat@chelsio.com \
--cc=bmt@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).