From: Leon Romanovsky <leon@kernel.org>
To: Bernard Metzler <BMT@zurich.ibm.com>
Cc: linux-rdma@vger.kernel.org, bharat@chelsio.com, jgg@ziepe.ca,
nirranjan@chelsio.com, krishna2@chelsio.com, bvanassche@acm.org
Subject: Re: Re: Re: [[PATCH v2 for-next]] RDMA/siw: Fix SQ/RQ drain logic
Date: Tue, 22 Oct 2019 08:49:49 +0300 [thread overview]
Message-ID: <20191022054949.GG4853@unreal> (raw)
In-Reply-To: <OFDD08DC35.6F2BAA59-ON00258497.004A2745-00258497.004C060F@notes.na.collabserv.com>
On Fri, Oct 18, 2019 at 01:50:22PM +0000, Bernard Metzler wrote:
> -----"Leon Romanovsky" <leon@kernel.org> wrote: -----
>
> >To: "Bernard Metzler" <BMT@zurich.ibm.com>
> >From: "Leon Romanovsky" <leon@kernel.org>
> >Date: 10/05/2019 10:26AM
> >Cc: linux-rdma@vger.kernel.org, bharat@chelsio.com, jgg@ziepe.ca,
> >nirranjan@chelsio.com, krishna2@chelsio.com, bvanassche@acm.org
> >Subject: [EXTERNAL] Re: Re: [[PATCH v2 for-next]] RDMA/siw: Fix SQ/RQ
> >drain logic
> >
> >On Fri, Oct 04, 2019 at 02:09:57PM +0000, Bernard Metzler wrote:
> >> -----"Leon Romanovsky" <leon@kernel.org> wrote: -----
> >> <...>
> >>
> >> >> *
> >> >> @@ -705,6 +746,12 @@ int siw_post_send(struct ib_qp *base_qp,
> >const
> >> >struct ib_send_wr *wr,
> >> >> unsigned long flags;
> >> >> int rv = 0;
> >> >>
> >> >> + if (wr && !qp->kernel_verbs) {
> >> >
> >> >It is not related to this specific patch, but all siw
> >"kernel_verbs"
> >> >should go, we have standard way to distinguish between kernel and
> >> >user
> >> >verbs.
> >> >
> >> >Thanks
> >> >
> >> Understood. I think we touched on that already.
> >> rdma core objects have a uobject pointer which
> >> is valid only if it belongs to a user land
> >> application. We might better use that. Let me
> >> see if I can compact QP objects to contain the
> >> ib_qp. I'd like to avoid following pointers
> >> potentially causing cache misses on the
> >> fast path. This is why I still have that
> >> little boolean within the siw private
> >> structure.
> >
> >You have this variable in CQ and SRQ too.
> >
> >I have serious doubts that this value gives any performance
> >advantages.
> >In both flows, you will need to fetch ib_qp pointer, so you don't
> >save
> >here anything by looking on kernel_verbs value.
> >
>
> Yes, I see you are right for both CQ and SRQ.
>
> For the CQ, we have a nested structure where
> siw_cq contains ib_cq. So it is not far away.
>
> For SRQ it is the same.
>
> For QP's we have a split between siw_qp and ib_qp.
> I will look into how to get that one solved.
>
> I will prepare an extra patch for that whole
> kernel_verbs thing, but let's not have it gating
> acceptance of this unrelated patch.
Sure, it is unrelated.
>
> Thanks very much,
> Bernard.
>
next prev parent reply other threads:[~2019-10-22 5:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 14:38 [[PATCH v2 for-next]] RDMA/siw: Fix SQ/RQ drain logic Bernard Metzler
2019-10-02 15:47 ` Leon Romanovsky
2019-10-04 14:09 ` Bernard Metzler
2019-10-04 17:48 ` Jason Gunthorpe
2019-10-05 8:26 ` Leon Romanovsky
2019-10-18 13:50 ` Bernard Metzler
2019-10-22 5:49 ` Leon Romanovsky [this message]
2019-10-25 12:11 ` Bernard Metzler
2019-10-27 5:21 ` Leon Romanovsky
2019-10-28 12:37 ` Bernard Metzler
2019-10-28 13:43 ` Jason Gunthorpe
2019-10-29 4:54 ` Leon Romanovsky
2019-10-31 13:38 ` Bernard Metzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022054949.GG4853@unreal \
--to=leon@kernel.org \
--cc=BMT@zurich.ibm.com \
--cc=bharat@chelsio.com \
--cc=bvanassche@acm.org \
--cc=jgg@ziepe.ca \
--cc=krishna2@chelsio.com \
--cc=linux-rdma@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).