From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1DA7C432C0 for ; Fri, 22 Nov 2019 06:53:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91FC520717 for ; Fri, 22 Nov 2019 06:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574405587; bh=dXDJjy7W4XEdvH5XAIzxJtf5kv3bcDRtjU4yreyOKj8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wrFmD8amjEFZ1JjN43e4PUY+eadm6vsaFEnND1/eTEh8++lOsje9hQdyOCzEB1UN0 ESWpdBqVjRwB/LbNac6+1aeMt+Lkl5Ax9o2hIjfsf1TRYFElneGenmnpXHCTUvPx+/ dkXfrSTeGcUQThZlweKN/W9R1hAiqFWdrF/xpCO4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726967AbfKVGxG (ORCPT ); Fri, 22 Nov 2019 01:53:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:42750 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726931AbfKVGxG (ORCPT ); Fri, 22 Nov 2019 01:53:06 -0500 Received: from localhost (unknown [5.29.147.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 857192070A; Fri, 22 Nov 2019 06:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574405586; bh=dXDJjy7W4XEdvH5XAIzxJtf5kv3bcDRtjU4yreyOKj8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m1GkL4cf/YLjkDmnBi8EMjwkasAE5e13Y005vcMtSgkfmTOMYZyDn3VTg36Irg/wk ShJ9UfJakZOF1J6w66P9J4imADXChMWtg6l/dPfn5hZA5sSS3Dc/sqr8oevRCVKpJa AjgLTmV0+ZpkSPOIEuIh6gW2aEE+UvNxPtoO7YPA= Date: Fri, 22 Nov 2019 08:53:03 +0200 From: Leon Romanovsky To: Ira Weiny Cc: Doug Ledford , Jason Gunthorpe , RDMA mailing list , Bart Van Assche , Sean Hefty Subject: Re: [PATCH rdma-next v1 03/48] RDMA/ucma: Mask QPN to be 24 bits according to IBTA Message-ID: <20191122065303.GB136476@unreal> References: <20191121181313.129430-1-leon@kernel.org> <20191121181313.129430-4-leon@kernel.org> <20191121213824.GA13840@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191121213824.GA13840@iweiny-DESK2.sc.intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Nov 21, 2019 at 01:38:24PM -0800, Ira Weiny wrote: > > diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c > > index 0274e9b704be..57e68491a2fd 100644 > > --- a/drivers/infiniband/core/ucma.c > > +++ b/drivers/infiniband/core/ucma.c > > @@ -1045,7 +1045,7 @@ static void ucma_copy_conn_param(struct rdma_cm_id *id, > > dst->retry_count = src->retry_count; > > dst->rnr_retry_count = src->rnr_retry_count; > > dst->srq = src->srq; > > - dst->qp_num = src->qp_num; > > + dst->qp_num = src->qp_num & 0xFFFFFF; > > Isn't src->qp_num coming from userspace? Why not return -EINVAL in such a > case? I afraid that it will break userspace application, we had similar case in uverbs, where we added WARN_ON() while masked PSN and got endless amount of bug reports from our enterprise colleagues who didn't clear memory above those 24bits and saw kernel splats. Thanks > > Ira >