From: Jakub Kicinski <kuba@kernel.org>
To: Michal Kalderon <mkalderon@marvell.com>
Cc: Ariel Elior <aelior@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2 net-next 00/13] qed*: Utilize FW 8.42.2.0
Date: Sun, 26 Jan 2020 12:30:14 -0800 [thread overview]
Message-ID: <20200126123014.0983991d@cakuba> (raw)
In-Reply-To: <MN2PR18MB318249831CD5207588443F6EA1080@MN2PR18MB3182.namprd18.prod.outlook.com>
On Sun, 26 Jan 2020 11:29:50 +0000, Michal Kalderon wrote:
> > On Thu, 23 Jan 2020 12:58:23 +0200, Michal Kalderon wrote:
> > > Changes from V1
> > > ---------------
> > > - Remove epoch + kernel version from device debug dump
> > > - don't bump driver version
> >
> > But you haven't fixed the fact that in patch 1 you already strat changing
> > defines for the new FW version, even though the version is only enforced
> > (reportedly) in patch 9?
>
> Right, I'll move the version change to patch #1 in V3.
>
> However, the entire series is required (except a few patches not prefixed with FW 8.42.2.0 ) to be
> taken to work correctly with the FW.
Right, exactly.
> Our FW is not backward/forward compatible.
Well, the driver can also be backward/forward compatible
(even if only for the short period of a series of patches)
as FW is usually more resource constrained.
> I have mentioned this in the cover letter, the split into smaller patches and prefix with
> FW 8.42.2.0 is to ease review and was done due to previous feedback that it is very difficult to review the FW patches:
>
> https://www.spinics.net/lists/linux-rdma/msg58810.html
>
> I am fine with squashing all the patches that are required to working with FW8.42.2.0 into one single patch if that is required and acceptable,
> But I believe that would make reviewing the changes more difficult.
The choice is not either one giant unreviewable patch or a driver
broken between commits. There are tens of Ethernet drivers in tree
and none of them seems to be having this issue.
Maybe Dave will let it fly this time around but you need to take
a hard look at your process for the future.
prev parent reply other threads:[~2020-01-26 20:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 10:58 [PATCH v2 net-next 00/13] qed*: Utilize FW 8.42.2.0 Michal Kalderon
2020-01-23 10:58 ` [PATCH v2 net-next 01/13] qed: FW 8.42.2.0 Internal ram offsets modifications Michal Kalderon
2020-01-23 10:58 ` [PATCH v2 net-next 02/13] qed: FW 8.42.2.0 Expose new registers and change windows Michal Kalderon
2020-01-23 10:58 ` [PATCH v2 net-next 03/13] qed: FW 8.42.2.0 Queue Manager changes Michal Kalderon
2020-01-23 10:58 ` [PATCH v2 net-next 04/13] qed: FW 8.42.2.0 Parser offsets modified Michal Kalderon
2020-01-23 10:58 ` [PATCH v2 net-next 05/13] qed: Use dmae to write to widebus registers in fw_funcs Michal Kalderon
2020-01-26 23:30 ` kbuild test robot
2020-01-27 23:39 ` kbuild test robot
2020-01-23 10:58 ` [PATCH v2 net-next 06/13] qed: FW 8.42.2.0 Additional ll2 type Michal Kalderon
2020-01-23 10:58 ` [PATCH v2 net-next 07/13] qed: Add abstraction for different hsi values per chip Michal Kalderon
2020-01-23 10:58 ` [PATCH v2 net-next 08/13] qed: FW 8.42.2.0 iscsi/fcoe changes Michal Kalderon
2020-01-23 10:58 ` [PATCH v2 net-next 09/13] qed: FW 8.42.2.0 HSI changes Michal Kalderon
2020-01-27 2:51 ` kbuild test robot
2020-01-28 3:45 ` kbuild test robot
2020-01-23 10:58 ` [PATCH v2 net-next 10/13] qed: FW 8.42.2.0 Add fw overlay feature Michal Kalderon
2020-01-23 10:58 ` [PATCH v2 net-next 11/13] qed: Debug feature: ilt and mdump Michal Kalderon
2020-01-27 6:00 ` kbuild test robot
2020-01-27 6:00 ` [RFC PATCH] qed: Debug feature: qed_dbg_ilt_get_dump_buf_size() can be static kbuild test robot
2020-01-23 10:58 ` [PATCH v2 net-next 12/13] qed: rt init valid initialization changed Michal Kalderon
2020-01-23 10:58 ` [PATCH v2 net-next 13/13] qed: FW 8.42.2.0 debug features Michal Kalderon
2020-01-27 8:57 ` kbuild test robot
2020-01-23 17:16 ` [PATCH v2 net-next 00/13] qed*: Utilize FW 8.42.2.0 Jakub Kicinski
2020-01-26 11:29 ` Michal Kalderon
2020-01-26 20:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126123014.0983991d@cakuba \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).