From: Max Gurtovoy <maxg@mellanox.com>
To: bvanassche@acm.org, jgg@mellanox.com, linux-rdma@vger.kernel.org,
dledford@redhat.com, leon@kernel.org
Cc: sagi@grimberg.me, israelr@mellanox.com, shlomin@mellanox.com,
Max Gurtovoy <maxg@mellanox.com>
Subject: [PATCH 0/8 v1] Remove FMR support from RDMA drivers
Date: Thu, 14 May 2020 15:02:57 +0300 [thread overview]
Message-ID: <20200514120305.189738-1-maxg@mellanox.com> (raw)
This series removes the support for FMR mode to register memory. This ancient
mode is unsafe and not maintained/tested in the last few years. It also doesn't
have any reasonable advantage over other memory registration methods such as
FRWR (that is implemented in all the recent RDMA adapters). This series should
be reviewed and approved by the maintainer of the effected drivers and I
suggest to test it as well.
The tests that I made for this series (fio benchmarks and fio verify data):
1. iSER initiator on ConnectX-4
2. iSER initiator on ConnectX-3
3. SRP initiator on ConnectX-4 (loopback to SRP target)
4. SRP initiator on ConnectX-3
Not tested:
1. RDS
2. mthca
3. rdmavt
Israel Rukshin (1):
RDMA/iser: Remove support for FMR memory registration
Max Gurtovoy (7):
RDMA/mlx4: remove FMR support for memory registration
RDMA/rds: remove FMR support for memory registration
RDMA/mthca: remove FMR support for memory registration
RDMA/rdmavt: remove FMR memory registration
RDMA/srp: remove support for FMR memory registration
RDMA/core: remove FMR pool API
RDMA/core: remove FMR device ops
Documentation/driver-api/infiniband.rst | 3 -
Documentation/infiniband/core_locking.rst | 2 -
drivers/infiniband/core/Makefile | 2 +-
drivers/infiniband/core/device.c | 4 -
drivers/infiniband/core/fmr_pool.c | 494 ---------------------------
drivers/infiniband/core/verbs.c | 48 ---
drivers/infiniband/hw/mlx4/main.c | 10 -
drivers/infiniband/hw/mlx4/mlx4_ib.h | 16 -
drivers/infiniband/hw/mlx4/mr.c | 93 -----
drivers/infiniband/hw/mthca/mthca_dev.h | 10 -
drivers/infiniband/hw/mthca/mthca_mr.c | 262 +-------------
drivers/infiniband/hw/mthca/mthca_provider.c | 86 -----
drivers/infiniband/sw/rdmavt/mr.c | 154 ---------
drivers/infiniband/sw/rdmavt/mr.h | 15 -
drivers/infiniband/sw/rdmavt/vt.c | 4 -
drivers/infiniband/ulp/iser/iscsi_iser.h | 79 +----
drivers/infiniband/ulp/iser/iser_initiator.c | 19 +-
drivers/infiniband/ulp/iser/iser_memory.c | 188 +---------
drivers/infiniband/ulp/iser/iser_verbs.c | 126 +------
drivers/infiniband/ulp/srp/ib_srp.c | 222 +-----------
drivers/infiniband/ulp/srp/ib_srp.h | 27 +-
drivers/net/ethernet/mellanox/mlx4/mr.c | 183 ----------
include/linux/mlx4/device.h | 21 +-
include/rdma/ib_fmr_pool.h | 93 -----
include/rdma/ib_verbs.h | 45 ---
net/rds/Makefile | 2 +-
net/rds/ib.c | 14 +-
net/rds/ib.h | 1 -
net/rds/ib_cm.c | 4 +-
net/rds/ib_fmr.c | 269 ---------------
net/rds/ib_mr.h | 12 -
net/rds/ib_rdma.c | 16 +-
32 files changed, 77 insertions(+), 2447 deletions(-)
delete mode 100644 drivers/infiniband/core/fmr_pool.c
delete mode 100644 include/rdma/ib_fmr_pool.h
delete mode 100644 net/rds/ib_fmr.c
--
1.8.3.1
next reply other threads:[~2020-05-14 12:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 12:02 Max Gurtovoy [this message]
2020-05-14 12:02 ` [PATCH 1/8] RDMA/mlx4: remove FMR support for memory registration Max Gurtovoy
2020-05-14 12:02 ` [PATCH 2/8] RDMA/rds: " Max Gurtovoy
2020-05-14 12:03 ` [PATCH 3/8] RDMA/mthca: " Max Gurtovoy
2020-05-14 12:03 ` [PATCH 4/8] RDMA/rdmavt: remove FMR " Max Gurtovoy
2020-05-14 12:03 ` [PATCH 5/8] RDMA/iser: Remove support for " Max Gurtovoy
2020-05-14 12:03 ` [PATCH 6/8] RDMA/srp: remove " Max Gurtovoy
2020-05-14 14:02 ` Bart Van Assche
2020-05-14 12:03 ` [PATCH 7/8] RDMA/core: remove FMR pool API Max Gurtovoy
2020-05-14 12:03 ` [PATCH 8/8] RDMA/core: remove FMR device ops Max Gurtovoy
2020-05-14 15:13 ` [PATCH 0/8 v1] Remove FMR support from RDMA drivers Aron Silverton
2020-05-14 18:18 ` santosh.shilimkar
2020-05-14 19:42 ` Max Gurtovoy
2020-05-14 22:23 ` Sagi Grimberg
2020-05-14 23:41 ` santosh.shilimkar
2020-05-15 16:52 ` Tom Talpey
2020-05-15 18:59 ` Sagi Grimberg
2020-05-17 10:51 ` Max Gurtovoy
2020-05-18 16:34 ` santosh.shilimkar
2020-05-15 0:37 ` Max Gurtovoy
2020-05-14 16:00 ` Gal Pressman
2020-05-17 10:37 ` Max Gurtovoy
2020-05-18 15:20 ` Dennis Dalessandro
2020-05-18 18:10 ` Jason Gunthorpe
2020-05-19 13:43 ` Dennis Dalessandro
2020-05-19 13:53 ` Jason Gunthorpe
2020-05-19 14:19 ` Leon Romanovsky
2020-05-19 14:26 ` Dennis Dalessandro
2020-05-19 14:30 ` Jason Gunthorpe
2020-05-19 14:37 ` Dennis Dalessandro
2020-05-23 22:08 ` Jason Gunthorpe
2020-05-24 1:27 ` Tom Talpey
2020-05-26 15:38 ` Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514120305.189738-1-maxg@mellanox.com \
--to=maxg@mellanox.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=israelr@mellanox.com \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).