From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Parav Pandit <parav@mellanox.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Dave Ertman <david.m.ertman@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"galpress@amazon.com" <galpress@amazon.com>,
"selvin.xavier@broadcom.com" <selvin.xavier@broadcom.com>,
"sriharsha.basavapatna@broadcom.com"
<sriharsha.basavapatna@broadcom.com>,
"benve@cisco.com" <benve@cisco.com>,
"bharat@chelsio.com" <bharat@chelsio.com>,
"xavier.huwei@huawei.com" <xavier.huwei@huawei.com>,
Yishai Hadas <yishaih@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>,
"mkalderon@marvell.com" <mkalderon@marvell.com>,
"aditr@vmware.com" <aditr@vmware.com>,
"ranjani.sridharan@linux.intel.com"
<ranjani.sridharan@linux.intel.com>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
Kiran Patil <kiran.patil@intel.com>,
Andrew Bowers <andrewx.bowers@intel.com>
Subject: Re: [net-next v4 01/12] Implementation of Virtual Bus
Date: Thu, 21 May 2020 19:43:58 +0200 [thread overview]
Message-ID: <20200521174358.GA3679752@kroah.com> (raw)
In-Reply-To: <c74808dc-0040-7cef-a0da-0da9caedddd9@mellanox.com>
On Thu, May 21, 2020 at 02:57:55PM +0000, Parav Pandit wrote:
> Hi Greg, Jason,
>
> On 5/20/2020 12:32 PM, Jeff Kirsher wrote:
> > From: Dave Ertman <david.m.ertman@intel.com>
> >
>
> > +static const
> > +struct virtbus_dev_id *virtbus_match_id(const struct virtbus_dev_id *id,
> > + struct virtbus_device *vdev)
> > +{
> > + while (id->name[0]) {
> > + if (!strcmp(vdev->match_name, id->name))
> > + return id;
>
> Should we have VID, DID based approach instead of _any_ string chosen by
> vendor drivers?
No, because:
> This will required central place to define the VID, DID of the vdev in
> vdev_ids.h to have unique ids.
That's not a good way to run things :)
Have the virtbus core create the "name", as it really doesn't matter
what it is, just that it is unique, right?
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-21 17:44 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 7:02 [net-next v4 00/12][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-19 Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 01/12] Implementation of Virtual Bus Jeff Kirsher
2020-05-21 14:57 ` Parav Pandit
2020-05-21 17:43 ` gregkh [this message]
2020-05-21 20:10 ` Jason Gunthorpe
2020-05-20 7:02 ` [net-next v4 02/12] ice: Create and register virtual bus for RDMA Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 03/12] ice: Complete RDMA peer registration Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 04/12] ice: Support resource allocation requests Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 05/12] ice: Enable event notifications Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 06/12] ice: Allow reset operations Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 07/12] ice: Pass through communications to VF Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 08/12] i40e: Move client header location Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 09/12] i40e: Register a virtbus device to provide RDMA Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client Jeff Kirsher
2020-05-20 7:20 ` Greg KH
2020-05-20 12:54 ` Jason Gunthorpe
2020-05-20 12:57 ` Jason Gunthorpe
2020-05-21 21:11 ` Ranjani Sridharan
2020-05-21 23:34 ` Jason Gunthorpe
2020-05-22 14:29 ` Pierre-Louis Bossart
2020-05-22 14:55 ` Jason Gunthorpe
2020-05-22 15:33 ` Pierre-Louis Bossart
2020-05-22 17:10 ` Jason Gunthorpe
2020-05-22 18:35 ` Pierre-Louis Bossart
2020-05-22 18:40 ` Jason Gunthorpe
2020-05-22 18:48 ` Pierre-Louis Bossart
2020-05-22 19:44 ` Jason Gunthorpe
2020-05-22 21:05 ` Pierre-Louis Bossart
2020-06-29 20:59 ` Mark Brown
2020-05-23 6:23 ` Greg KH
2020-05-23 19:41 ` Pierre-Louis Bossart
2020-05-24 6:35 ` Greg KH
2020-05-26 13:15 ` Pierre-Louis Bossart
2020-05-26 13:37 ` Takashi Iwai
2020-05-27 7:17 ` Greg KH
2020-05-27 14:05 ` Pierre-Louis Bossart
2020-06-29 20:33 ` Mark Brown
2020-06-29 22:59 ` Jason Gunthorpe
2020-06-29 23:13 ` Kirsher, Jeffrey T
2020-06-30 10:31 ` Mark Brown
2020-06-30 11:32 ` Jason Gunthorpe
2020-06-30 14:16 ` Mark Brown
2020-06-30 17:24 ` Ranjani Sridharan
2020-06-30 17:27 ` Jason Gunthorpe
2020-07-01 9:50 ` Mark Brown
2020-07-01 23:32 ` Jason Gunthorpe
2020-07-02 11:15 ` Mark Brown
2020-07-02 12:11 ` Jason Gunthorpe
2020-07-02 12:20 ` Mark Brown
2020-07-01 6:59 ` Greg KH
2020-07-02 13:43 ` Ranjani Sridharan
2020-07-06 23:02 ` Dan Williams
2020-07-07 14:16 ` Greg KH
2020-05-25 16:55 ` Jason Gunthorpe
2020-06-29 20:21 ` Mark Brown
2020-06-29 17:36 ` Mark Brown
2020-05-20 7:02 ` [net-next v4 11/12] ASoC: SOF: Create client driver for IPC test Jeff Kirsher
2020-05-20 7:22 ` Greg KH
2020-05-20 12:56 ` Jason Gunthorpe
2020-05-27 20:18 ` Ranjani Sridharan
2020-05-28 0:12 ` Jason Gunthorpe
2020-05-28 1:40 ` Ranjani Sridharan
2020-05-28 10:45 ` Greg KH
2020-06-29 20:37 ` Mark Brown
2020-05-20 7:02 ` [net-next v4 12/12] ASoC: SOF: ops: Add new op for client registration Jeff Kirsher
2020-05-20 7:23 ` Greg KH
2020-05-20 7:17 ` [net-next v4 00/12][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-19 Greg KH
2020-05-20 7:25 ` Kirsher, Jeffrey T
2020-05-20 9:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521174358.GA3679752@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aditr@vmware.com \
--cc=andrewx.bowers@intel.com \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=galpress@amazon.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jgg@ziepe.ca \
--cc=kiran.patil@intel.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=parav@mellanox.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sassmann@redhat.com \
--cc=selvin.xavier@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=xavier.huwei@huawei.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).