From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
"Yishai Hadas" <yishaih@mellanox.com>
Subject: Re: [PATCH rdma-next 5/5] RDMA/core: Convert RWQ table logic to ib_core allocation scheme
Date: Tue, 30 Jun 2020 08:37:29 -0300 [thread overview]
Message-ID: <20200630113729.GC23676@nvidia.com> (raw)
In-Reply-To: <20200630072137.GC17857@unreal>
On Tue, Jun 30, 2020 at 10:21:37AM +0300, Leon Romanovsky wrote:
> On Mon, Jun 29, 2020 at 12:39:07PM -0300, Jason Gunthorpe wrote:
> > On Wed, Jun 24, 2020 at 01:54:22PM +0300, Leon Romanovsky wrote:
> > > @@ -4018,8 +4028,7 @@ const struct uapi_definition uverbs_def_write_intf[] = {
> > > IB_USER_VERBS_EX_CMD_DESTROY_RWQ_IND_TBL,
> > > ib_uverbs_ex_destroy_rwq_ind_table,
> > > UAPI_DEF_WRITE_I(
> > > - struct ib_uverbs_ex_destroy_rwq_ind_table),
> > > - UAPI_DEF_METHOD_NEEDS_FN(destroy_rwq_ind_table))),
> > > + struct ib_uverbs_ex_destroy_rwq_ind_table))),
> >
> > Removing these is kind of troublesome.. This misses the one for ioctl:
> >
> > UAPI_DEF_CHAIN_OBJ_TREE_NAMED(
> > UVERBS_OBJECT_RWQ_IND_TBL,
> > UAPI_DEF_OBJ_NEEDS_FN(destroy_rwq_ind_table)),
>
> I will remove, but it seems that we have some gap here, I would expect
> any sort of compilation error for mlx4.
Why would there be a compilation error?
And it should not be removed, it needs to be reworked to point to some
other function I suppose.
Jason
next prev parent reply other threads:[~2020-06-30 11:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 10:54 [PATCH rdma-next 0/5] ib_core allocation patches Leon Romanovsky
2020-06-24 10:54 ` [PATCH rdma-next 1/5] RDMA/core: Create and destroy counters in the ib_core Leon Romanovsky
2020-06-24 10:54 ` [PATCH rdma-next 2/5] RDMA: Clean MW allocation and free flows Leon Romanovsky
2020-06-28 9:18 ` Yishai Hadas
2020-06-28 9:55 ` Leon Romanovsky
2020-06-24 10:54 ` [PATCH rdma-next 3/5] RDMA: Move XRCD to be under ib_core responsibility Leon Romanovsky
2020-06-24 10:54 ` [PATCH rdma-next 4/5] RDMA/core: Delete not-used create RWQ table function Leon Romanovsky
2020-06-24 19:46 ` Jason Gunthorpe
2020-06-24 10:54 ` [PATCH rdma-next 5/5] RDMA/core: Convert RWQ table logic to ib_core allocation scheme Leon Romanovsky
2020-06-28 9:11 ` Yishai Hadas
2020-06-28 9:41 ` Leon Romanovsky
2020-06-28 10:08 ` Yishai Hadas
2020-06-28 10:33 ` Leon Romanovsky
2020-06-28 11:55 ` Yishai Hadas
2020-06-28 13:10 ` Leon Romanovsky
2020-06-29 15:39 ` Jason Gunthorpe
2020-06-30 7:21 ` Leon Romanovsky
2020-06-30 11:37 ` Jason Gunthorpe [this message]
2020-06-30 11:52 ` Leon Romanovsky
2020-06-30 12:06 ` Jason Gunthorpe
2020-06-30 12:13 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630113729.GC23676@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).