From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D06C433E0 for ; Sun, 5 Jul 2020 18:04:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF0A72073E for ; Sun, 5 Jul 2020 18:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593972260; bh=1XAoZrtE6FWEVtc/LMKlS3FddW6mojZo4iCmWkNF/3g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=oo74WLICqqZ9wJ7M/BG0W6Wq9NymOGNGlNu91vsEudtJoWSLTR1KDehcgcC0vSLvt JpQXrXpL6Gu2Vqr51pes5xkU9vUMWczm3CAoFkZS5/nw50WUf/8iVodaifrpxiZNRz B7Koh+vZCcNzqWXuBKwlOXn/N6xeKeYPdQ6KRs9o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727823AbgGESET (ORCPT ); Sun, 5 Jul 2020 14:04:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:51888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727781AbgGESET (ORCPT ); Sun, 5 Jul 2020 14:04:19 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B16520708; Sun, 5 Jul 2020 18:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593972258; bh=1XAoZrtE6FWEVtc/LMKlS3FddW6mojZo4iCmWkNF/3g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bls+zQ2GBo4Ttn58ZYE3HcayL/yhVp3pqiChFEL4bMoxY3wyytC6BkxZW/rfWvJtD Jr47wZJep/myYe4SYHXApJjzp/JH4m37J9I4VD1zcp06kvxvVAYQMhmvYFKrwS5qGn RRuhkd0Mk6uj3lYiHJWVHqRv9Oot+ManFz1HcRb0= Date: Sun, 5 Jul 2020 21:04:15 +0300 From: Leon Romanovsky To: David Ahern Cc: Maor Gottlieb , Doug Ledford , Jason Gunthorpe , linux-netdev , RDMA mailing list Subject: Re: [PATCH iproute2-next v1 1/4] rdma: update uapi headers Message-ID: <20200705180415.GB207186@unreal> References: <20200624104012.1450880-1-leon@kernel.org> <20200624104012.1450880-2-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Sun, Jul 05, 2020 at 09:02:42AM -0600, David Ahern wrote: > On 6/24/20 4:40 AM, Leon Romanovsky wrote: > > diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h > > index ae5a77a1..fe127b88 100644 > > --- a/rdma/include/uapi/rdma/rdma_netlink.h > > +++ b/rdma/include/uapi/rdma/rdma_netlink.h > > @@ -287,6 +287,12 @@ enum rdma_nldev_command { > > > > RDMA_NLDEV_CMD_STAT_DEL, > > > > + RDMA_NLDEV_CMD_RES_QP_GET_RAW, /* can dump */ > > + > > + RDMA_NLDEV_CMD_RES_CQ_GET_RAW, /* can dump */ > > + > > + RDMA_NLDEV_CMD_RES_MR_GET_RAW, /* can dump */ > > + > > RDMA_NLDEV_NUM_OPS > > }; > > you are inserting new commands in the middle which breaks existing users > of this API. RDMA_NLDEV_NUM_OPS is not a command, but enum item to help calculate array size, exactly like devlink_command in include/uapi/linux/devlink.h. Thanks >