From: "hch@lst.de" <hch@lst.de>
To: Parav Pandit <parav@nvidia.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
syzbot <syzbot+34dc2fea3478e659af01@syzkaller.appspotmail.com>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>, "hch@lst.de" <hch@lst.de>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linaro-mm-sig-owner@lists.linaro.org"
<linaro-mm-sig-owner@lists.linaro.org>,
"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
"syzkaller-bugs@googlegroups.com"
<syzkaller-bugs@googlegroups.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: WARNING in dma_map_page_attrs
Date: Tue, 27 Oct 2020 09:11:03 +0100 [thread overview]
Message-ID: <20201027081103.GA22877@lst.de> (raw)
In-Reply-To: <BY5PR12MB4322CC03CE0D34B83269676ADC190@BY5PR12MB4322.namprd12.prod.outlook.com>
On Mon, Oct 26, 2020 at 05:23:48AM +0000, Parav Pandit wrote:
> Hi Christoph,
>
> > From: Jakub Kicinski <kuba@kernel.org>
> > Sent: Saturday, October 24, 2020 11:45 PM
> >
> > CC: rdma, looks like rdma from the stack trace
> >
> > On Fri, 23 Oct 2020 20:07:17 -0700 syzbot wrote:
> > > syzbot has found a reproducer for the following issue on:
> > >
> > > HEAD commit: 3cb12d27 Merge tag 'net-5.10-rc1' of git://git.kernel.org/..
>
> In [1] you mentioned that dma_mask should not be set for dma_virt_ops.
> So patch [2] removed it.
>
> But check to validate the dma mask for all dma_ops was added in [3].
>
> What is the right way? Did I misunderstood your comment about dma_mask in [1]?
No, I did not say we don't need the mask. I said copying over the
various dma-related fields from the parent is bogus.
I think rxe (and ther other drivers/infiniband/sw drivers) need a simple
dma_coerce_mask_and_coherent and nothing else.
next prev parent reply other threads:[~2020-10-27 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <000000000000335adc05b23300f6@google.com>
[not found] ` <000000000000a0f8a305b261fe4a@google.com>
2020-10-24 18:15 ` WARNING in dma_map_page_attrs Jakub Kicinski
2020-10-26 5:23 ` Parav Pandit
2020-10-27 8:11 ` hch [this message]
2020-10-27 12:52 ` Parav Pandit
2020-10-28 17:31 ` hch
2020-10-30 9:35 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027081103.GA22877@lst.de \
--to=hch@lst.de \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kuba@kernel.org \
--cc=linaro-mm-sig-owner@lists.linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=syzbot+34dc2fea3478e659af01@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).