From: Jason Gunthorpe <jgg@nvidia.com>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: <kjlu@umn.edu>, Christian Benvenuti <benve@cisco.com>,
Nelson Escobar <neescoba@cisco.com>,
Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/usnic: Fix memleak in find_free_vf_and_create_qp_grp
Date: Thu, 7 Jan 2021 16:41:15 -0400 [thread overview]
Message-ID: <20210107204115.GA933040@nvidia.com> (raw)
In-Reply-To: <20201226074248.2893-1-dinghao.liu@zju.edu.cn>
On Sat, Dec 26, 2020 at 03:42:48PM +0800, Dinghao Liu wrote:
> If usnic_ib_qp_grp_create() fails at the first call, dev_list
> will not be freed on error, which leads to memleak.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied to for-rc with
Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver")
Thanks,
Jason
prev parent reply other threads:[~2021-01-07 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 7:42 [PATCH] RDMA/usnic: Fix memleak in find_free_vf_and_create_qp_grp Dinghao Liu
2020-12-27 7:24 ` Leon Romanovsky
2021-01-07 20:41 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107204115.GA933040@nvidia.com \
--to=jgg@nvidia.com \
--cc=benve@cisco.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=dledford@redhat.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=neescoba@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).