From: Wan Jiabing <wanjiabing@vivo.com>
To: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kamal Heib <kamalheib1@gmail.com>,
Alaa Hleihel <alaa@mellanox.com>,
Wan Jiabing <wanjiabing@vivo.com>,
Valentine Fatiev <valentinef@mellanox.com>,
Christoph Lameter <cl@linux.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kael_w@yeah.net
Subject: [PATCH] infiniband: ulp: Remove unnecessary struct declaration
Date: Thu, 15 Apr 2021 17:21:16 +0800 [thread overview]
Message-ID: <20210415092124.27684-1-wanjiabing@vivo.com> (raw)
struct ipoib_cm_tx is defined at 245th line.
And the definition is independent on the MACRO.
The declaration here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/infiniband/ulp/ipoib/ipoib.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h
index 179ff1d068e5..d255aa69ba6d 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib.h
+++ b/drivers/infiniband/ulp/ipoib/ipoib.h
@@ -677,8 +677,6 @@ void ipoib_cm_handle_rx_wc(struct net_device *dev, struct ib_wc *wc);
void ipoib_cm_handle_tx_wc(struct net_device *dev, struct ib_wc *wc);
#else
-struct ipoib_cm_tx;
-
#define ipoib_max_conn_qp 0
static inline int ipoib_cm_admin_enabled(struct net_device *dev)
--
2.25.1
next reply other threads:[~2021-04-15 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 9:21 Wan Jiabing [this message]
2021-04-15 9:47 ` [PATCH] infiniband: ulp: Remove unnecessary struct declaration Christoph Lameter
2021-04-20 19:09 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415092124.27684-1-wanjiabing@vivo.com \
--to=wanjiabing@vivo.com \
--cc=alaa@mellanox.com \
--cc=cl@linux.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kael_w@yeah.net \
--cc=kamalheib1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=valentinef@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).