From: Jason Gunthorpe <jgg@ziepe.ca>
To: Shai Malin <smalin@marvell.com>
Cc: Leon Romanovsky <leon@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ariel Elior <aelior@marvell.com>,
"malin1024@gmail.com" <malin1024@gmail.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] qed: Enable RDMA relaxed ordering
Date: Thu, 26 Aug 2021 10:06:30 -0300 [thread overview]
Message-ID: <20210826130630.GD1200268@ziepe.ca> (raw)
In-Reply-To: <SJ0PR18MB3882237C8D74EB4A93A711DFCCC79@SJ0PR18MB3882.namprd18.prod.outlook.com>
On Thu, Aug 26, 2021 at 12:05:18PM +0000, Shai Malin wrote:
> On Mon, Aug 23, 2021 at 02:52:21PM +0300, Leon Romanovsky wrote:
> > +RDMA
> >
> > Jakub, David
> >
> > Can we please ask that everything directly or indirectly related to RDMA
> > will be sent to linux-rdma@ too?
>
> In addition to all that was discussed regarding qed_rdma.c
> and qed_rdma_ops - certainly, everything directly or indirectly
> related to RDMA will be sent to linux-rdma.
>
> >
> > On Sun, Aug 22, 2021 at 09:54:48PM +0300, Shai Malin wrote:
> > > Enable the RoCE and iWARP FW relaxed ordering.
> > >
> > > Signed-off-by: Ariel Elior <aelior@marvell.com>
> > > Signed-off-by: Shai Malin <smalin@marvell.com>
> > > drivers/net/ethernet/qlogic/qed/qed_rdma.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> > b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> > > index 4f4b79250a2b..496092655f26 100644
> > > +++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> > > @@ -643,6 +643,8 @@ static int qed_rdma_start_fw(struct qed_hwfn
> > *p_hwfn,
> > > cnq_id);
> > > }
> > >
> > > + p_params_header->relaxed_ordering = 1;
> >
> > Maybe it is only description that needs to be updated, but I would
> > expect to see call to pcie_relaxed_ordering_enabled() before setting
> > relaxed_ordering to always true.
>
> This change will only allow the FW to support relaxed ordering but it
> will be enabled only if the device/root-complex/server supports
> relaxed ordering.
> The pcie_relaxed_ordering_enabled() is not needed in this case.
I'm confused, our RDMA model is not to blanket enable relaxed
ordering, we set out rules that the driver has to follow when a
relaxed ordering TLP can be issued:
- QP/CQ/etc internal queues - device decision based on correctness
- Kernel created MRs - always
- User created MRs - only if IB_ACCESS_RELAXED_ORDERING is set
So what does this flag do, and does it follow this model?
Jason
next prev parent reply other threads:[~2021-08-26 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 12:05 [PATCH] qed: Enable RDMA relaxed ordering Shai Malin
2021-08-26 13:06 ` Jason Gunthorpe [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-26 13:40 Shai Malin
[not found] <20210822185448.12053-1-smalin@marvell.com>
2021-08-23 11:52 ` Leon Romanovsky
2021-08-23 13:33 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826130630.GD1200268@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=malin1024@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=smalin@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).