linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Ledford <dledford@redhat.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Adit Ranadive <aditr@vmware.com>
Cc: Potnuri Bharat Teja <bharat@chelsio.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"nirranjan@chelsio.com" <nirranjan@chelsio.com>
Subject: Re: [PATCH for-next] iw_cxgb3: remove iw_cxgb3 module from kernel.
Date: Fri, 18 Oct 2019 16:49:43 -0400	[thread overview]
Message-ID: <93a0c381172f05a0256af82f702faa2d4068a24a.camel@redhat.com> (raw)
In-Reply-To: <20191018204747.GB6087@ziepe.ca>

[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]

On Fri, 2019-10-18 at 17:47 -0300, Jason Gunthorpe wrote:
> On Thu, Oct 17, 2019 at 06:41:16AM +0000, Adit Ranadive wrote:
> > On 10/4/19, 11:12 AM, "Jason Gunthorpe" <jgg@ziepe.ca> wrote:
> > > On Mon, Sep 30, 2019 at 01:12:52PM +0530, Potnuri Bharat Teja
> > > wrote:
> > > > remove iw_cxgb3 module from kernel as the corresponding HW
> > > > Chelsio T3 has
> > > > reached EOL.
> > > > 
> > > > Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
> > > 
> > > Applied to for-next
> > > 
> > > Please also send a PR to delete cxgb3 from rdma-core
> > > 
> > 
> > Is Chelsio going to send a PR for the deletion? It looks like
> > otherwise
> > rdma-core is broken for other providers when running with the for-
> > next branch.
> > 
> > Also, it looks like the kernel-headers/update script in rdma-core
> > needs to be
> > updated to remove a header if required from the
> > rdma_kernel_provider_abi
> > section. Or is that expected to be manual?
> 
> Manual is probably fine, this doesn't happen often
> 
> And the bug introduced in this patch is just a bug that should be
> fixed in the kernel now

I pushed that fix out already.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-10-18 20:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30  7:42 [PATCH for-next] iw_cxgb3: remove iw_cxgb3 module from kernel Potnuri Bharat Teja
2019-10-04 18:11 ` Jason Gunthorpe
2019-10-17  6:41   ` Adit Ranadive
2019-10-17  8:29     ` Potnuri Bharat Teja
2019-10-18 20:47     ` Jason Gunthorpe
2019-10-18 20:49       ` Doug Ledford [this message]
2019-10-10 14:26 ` Michal Kalderon
2019-10-16 17:47 ` Don Dutile
2019-10-17  6:06   ` Leon Romanovsky
2019-10-18 20:46   ` Jason Gunthorpe
2019-10-18 20:51     ` Doug Ledford
2019-10-18 22:50       ` Don Dutile

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93a0c381172f05a0256af82f702faa2d4068a24a.camel@redhat.com \
    --to=dledford@redhat.com \
    --cc=aditr@vmware.com \
    --cc=bharat@chelsio.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=nirranjan@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).