From: Bart Van Assche <bvanassche@acm.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Wang Wensheng <wangwensheng4@huawei.com>,
dledford@redhat.com, linux-rdma@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
rui.xiang@huawei.com
Subject: Re: [PATCH -next] RDMA/srpt: Fix error return code in srpt_cm_req_recv()
Date: Mon, 12 Apr 2021 11:46:26 -0700 [thread overview]
Message-ID: <966eef91-0eee-beea-b927-7a4aa1b8fbd4@acm.org> (raw)
In-Reply-To: <20210412180904.GA1152997@nvidia.com>
On 4/12/21 11:09 AM, Jason Gunthorpe wrote:
> On Thu, Apr 08, 2021 at 09:50:30AM -0700, Bart Van Assche wrote:
>> On 4/8/21 4:31 AM, Wang Wensheng wrote:
>>> Fix to return a negative error code from the error handling
>>> case instead of 0, as done elsewhere in this function.
>>>
>>> Fixes: db7683d7deb2 ("IB/srpt: Fix login-related race conditions")
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
>>> drivers/infiniband/ulp/srpt/ib_srpt.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
>>> index 98a393d..ea44780 100644
>>> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
>>> @@ -2382,6 +2382,7 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev,
>>> pr_info("rejected SRP_LOGIN_REQ because target %s_%d is not enabled\n",
>>> dev_name(&sdev->device->dev), port_num);
>>> mutex_unlock(&sport->mutex);
>>> + ret = -EINVAL;
>>> goto reject;
>>> }
>>
>> Please fix the Hulk Robot. The following code occurs three lines above
>> the modified code:
>>
>> ret = -EINVAL;
>
> That is a different if.
>
> The patch looks correct to me, please check again:
>
> ret = srpt_create_ch_ib(ch);
> if (ret) {
> // Ret is proven to be 0
>
> [..]
>
> if (!sport->enabled) {
> rej->reason = cpu_to_be32(
> SRP_LOGIN_REJ_INSUFFICIENT_RESOURCES);
> pr_info("rejected SRP_LOGIN_REQ because target %s_%d is not enabled\n",
> dev_name(&sdev->device->dev), port_num);
> goto reject; // Ret is 0
>
> If there is an assignment to ret between those two blocks it is hidden..
Right, I was looking at another if-statement in the same function.
Bart.
next prev parent reply other threads:[~2021-04-12 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 11:31 [PATCH -next] RDMA/srpt: Fix error return code in srpt_cm_req_recv() Wang Wensheng
2021-04-08 16:50 ` Bart Van Assche
2021-04-12 18:09 ` Jason Gunthorpe
2021-04-12 18:46 ` Bart Van Assche [this message]
2021-04-12 18:47 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=966eef91-0eee-beea-b927-7a4aa1b8fbd4@acm.org \
--to=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rui.xiang@huawei.com \
--cc=target-devel@vger.kernel.org \
--cc=wangwensheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).