From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B3D9ECDE20 for ; Wed, 11 Sep 2019 07:50:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 416B720CC7 for ; Wed, 11 Sep 2019 07:50:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbfIKHum convert rfc822-to-8bit (ORCPT ); Wed, 11 Sep 2019 03:50:42 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:41710 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725616AbfIKHum (ORCPT ); Wed, 11 Sep 2019 03:50:42 -0400 Received: from dggeml405-hub.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id 12C574AEEB1EF227AB40; Wed, 11 Sep 2019 15:50:41 +0800 (CST) Received: from DGGEML424-HUB.china.huawei.com (10.1.199.41) by dggeml405-hub.china.huawei.com (10.3.17.49) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Sep 2019 15:50:40 +0800 Received: from DGGEML522-MBX.china.huawei.com ([169.254.7.213]) by dggeml424-hub.china.huawei.com ([10.1.199.41]) with mapi id 14.03.0439.000; Wed, 11 Sep 2019 15:50:33 +0800 From: liweihang To: Leon Romanovsky CC: "dledford@redhat.com" , "jgg@ziepe.ca" , "linux-rdma@vger.kernel.org" , Linuxarm Subject: RE: [PATCH rdma-core 3/5] libhns: Refactor for post send Thread-Topic: [PATCH rdma-core 3/5] libhns: Refactor for post send Thread-Index: AQHVZ9K2jRVGOt9uOUuq4H9FaamW1KclkUEAgACKFrA= Date: Wed, 11 Sep 2019 07:50:33 +0000 Message-ID: References: <1568118052-33380-1-git-send-email-liweihang@hisilicon.com> <1568118052-33380-4-git-send-email-liweihang@hisilicon.com> <20190911073538.GC6601@unreal> In-Reply-To: <20190911073538.GC6601@unreal> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.40.168.149] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org > -----Original Message----- > From: Leon Romanovsky [mailto:leon@kernel.org] > Sent: Wednesday, September 11, 2019 3:36 PM > To: liweihang > Cc: dledford@redhat.com; jgg@ziepe.ca; linux-rdma@vger.kernel.org; > Linuxarm > Subject: Re: [PATCH rdma-core 3/5] libhns: Refactor for post send > > On Tue, Sep 10, 2019 at 08:20:50PM +0800, Weihang Li wrote: > > From: Yixian Liu > > > > This patch refactors the interface of hns_roce_u_v2_post_send, which > > is now very complicated. We reduce the complexity with following points: > > 1. Separate RC server into a function. > > 2. Simplify and separate the process of sge. > > 3. Keep the logic and consistence of all operations. > > > > Signed-off-by: Yixian Liu > > Signed-off-by: Weihang Li > > --- > > providers/hns/hns_roce_u.h | 7 + > > providers/hns/hns_roce_u_hw_v2.c | 427 > > ++++++++++++++++----------------------- > > 2 files changed, 186 insertions(+), 248 deletions(-) > > > > No printf() calls in the providers code, please. > > Thanks OK, will modify them, thank you.