From: Steve Wise <larrystevenwise@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-rdma <linux-rdma@vger.kernel.org>,
wangqi <3100102071@zju.edu.cn>, Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH 2/2] rxe: correctly calculate iCRC for unaligned payloads
Date: Tue, 3 Dec 2019 12:32:58 -0600 [thread overview]
Message-ID: <CADmRdJfGBt-k1uXZK3Uvjkj0hyCOoPjBzxx_UmRKUq7rcQ1ouQ@mail.gmail.com> (raw)
In-Reply-To: <a0003c88-10f5-c14a-220d-c100fa160163@acm.org>
On Tue, Dec 3, 2019 at 10:25 AM Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 12/2/19 6:03 PM, Steve Wise wrote:
> > If RoCE PDUs being sent or received contain pad bytes, then the iCRC
> > is miscalculated resulting PDUs being emitted by RXE with an incorrect
> > iCRC, as well as ingress PDUs being dropped due to erroneously detecting
> > a bad iCRC in the PDU. The fix is to include the pad bytes, if any,
> > in iCRC computations.
>
> Should this description mention that this patch breaks compatibility
> with SoftRoCE drivers that do not include this fix? Do we need a kernel
> module parameter that allows to select either the old or the new behavior?
>
Good point. I defer to others on how they want to handle that.
> > CC: bvanassche@acm.org,3100102071@zju.edu.cn,leon@kernel.org
>
> Should this Cc-line perhaps be converted into three Cc-lines?
Yea I screwed this up. I really didn't want this in the commit log
vs just CCing on the email submission, but I was having issues with
git send-email. Pilot error. ;)
Stevo
next prev parent reply other threads:[~2019-12-03 18:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 2:03 [PATCH 1/2] Update mailmap info for Steve Wise Steve Wise
2019-12-03 2:03 ` [PATCH 2/2] rxe: correctly calculate iCRC for unaligned payloads Steve Wise
2019-12-03 16:25 ` Bart Van Assche
2019-12-03 18:32 ` Steve Wise [this message]
2019-12-04 0:46 ` Doug Ledford
2019-12-09 19:07 ` Doug Ledford
2019-12-10 6:54 ` Leon Romanovsky
2019-12-11 4:24 ` Doug Ledford
2019-12-11 5:59 ` Leon Romanovsky
2019-12-11 14:42 ` Tom Talpey
2019-12-12 22:06 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADmRdJfGBt-k1uXZK3Uvjkj0hyCOoPjBzxx_UmRKUq7rcQ1ouQ@mail.gmail.com \
--to=larrystevenwise@gmail.com \
--cc=3100102071@zju.edu.cn \
--cc=bvanassche@acm.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).