From: Jinpu Wang <jinpu.wang@cloud.ionos.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jack Wang <jinpuwang@gmail.com>,
linux-block@vger.kernel.org, linux-rdma@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
Sagi Grimberg <sagi@grimberg.me>,
Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Danil Kipnis <danil.kipnis@cloud.ionos.com>,
rpenyaev@suse.de
Subject: Re: [PATCH v6 08/25] rtrs: client: sysfs interface functions
Date: Fri, 3 Jan 2020 15:59:07 +0100 [thread overview]
Message-ID: <CAMGffEk+XSSdLU==O5inqEc2UycSaB7K1+vqkof=4RDnN4pp6Q@mail.gmail.com> (raw)
In-Reply-To: <8be61a28-baf7-99dd-c94d-53244565906f@acm.org>
On Thu, Jan 2, 2020 at 10:14 PM Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 12/30/19 2:29 AM, Jack Wang wrote:
> > +static struct kobj_type ktype = {
> > + .sysfs_ops = &kobj_sysfs_ops,
> > +};
>
> Can this data structure be declared 'const'?
No, kobject_init_and_add expect sturct kobj_type *.
>
> > +static ssize_t max_reconnect_attempts_show(struct device *dev,
> > + struct device_attribute *attr,
> > + char *page)
> > +{
> > + struct rtrs_clt *clt;
> > +
> > + clt = container_of(dev, struct rtrs_clt, dev);
>
> If the above two statements would be combined into a single statement,
> does the result still fit in 80 columns? If so, please combine these two
> statements into a single statement.
ok.
>
> > +static ssize_t max_reconnect_attempts_store(struct device *dev,
> > + struct device_attribute *attr,
> > + const char *buf,
> > + size_t count)
> > +{
> > + struct rtrs_clt *clt;
> > + int value;
> > + int ret;
> > +
> > + clt = container_of(dev, struct rtrs_clt, dev);
>
> Same comment here and also for other uses of 'clt': how about combining
> the declaration and initialization of 'clt' into a single line of code?
ok.
>
> > +static ssize_t mpath_policy_show(struct device *dev,
> > + struct device_attribute *attr,
> > + char *page)
> > +{
> > + struct rtrs_clt *clt;
> > +
> > + clt = container_of(dev, struct rtrs_clt, dev);
> > +
> > + switch (clt->mp_policy) {
> > + case MP_POLICY_RR:
> > + return sprintf(page, "round-robin (RR: %d)\n", clt->mp_policy);
> > + case MP_POLICY_MIN_INFLIGHT:
> > + return sprintf(page, "min-inflight (MI: %d)\n", clt->mp_policy);
> > + default:
> > + return sprintf(page, "Unknown (%d)\n", clt->mp_policy);
> > + }
> > +}
>
> Is the above show function compatible with the sysfs one-value-per-file
> rule?
It's a single string :)
>
> > +static struct kobj_attribute rtrs_clt_remove_path_attr =
> > + __ATTR(remove_path, 0644, rtrs_clt_remove_path_show,
> > + rtrs_clt_remove_path_store);
>
> Could __ATTR_RW() have been used here?
can be used, but I prefer to keep the rtrs_clt_ prefix for function names.
>
> > +static struct kobj_attribute rtrs_clt_src_addr_attr =
> > + __ATTR(src_addr, 0444, rtrs_clt_src_addr_show, NULL);
>
> Could __ATTR_RO() have been used here?
dito.
>
> > +static struct attribute_group rtrs_clt_sess_attr_group = {
> > + .attrs = rtrs_clt_sess_attrs,
> > +};
>
> Can this data structure be declared 'const'?
Yes.
>
> Thanks,
>
> Bart.
Thanks
next prev parent reply other threads:[~2020-01-03 14:59 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 10:29 [PATCH v6 00/25] RTRS (former IBTRS) rdma transport library and RNBD (former IBNBD) rdma network block device Jack Wang
2019-12-30 10:29 ` [PATCH v6 01/25] sysfs: export sysfs_remove_file_self() Jack Wang
2019-12-30 10:29 ` [PATCH v6 02/25] rtrs: public interface header to establish RDMA connections Jack Wang
2019-12-30 19:25 ` Bart Van Assche
2020-01-02 13:35 ` Jinpu Wang
2020-01-02 16:36 ` Bart Van Assche
2020-01-02 16:47 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 03/25] rtrs: private headers with rtrs protocol structs and helpers Jack Wang
2019-12-30 19:48 ` Bart Van Assche
2020-01-02 15:27 ` Jinpu Wang
2020-01-02 17:00 ` Bart Van Assche
2020-01-02 18:26 ` Jason Gunthorpe
2020-01-03 12:31 ` Jinpu Wang
2020-01-03 12:27 ` Jinpu Wang
2019-12-31 0:07 ` Bart Van Assche
2020-01-03 13:48 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 04/25] rtrs: core: lib functions shared between client and server modules Jack Wang
2019-12-30 22:25 ` Bart Van Assche
2020-01-07 12:22 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 05/25] rtrs: client: private header with client structs and functions Jack Wang
2019-12-30 22:51 ` Bart Van Assche
2020-01-07 12:39 ` Jinpu Wang
2019-12-30 23:03 ` Bart Van Assche
2020-01-07 12:39 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 06/25] rtrs: client: main functionality Jack Wang
2019-12-30 23:53 ` Bart Van Assche
2020-01-02 18:23 ` Jason Gunthorpe
2020-01-03 14:30 ` Jinpu Wang
2020-01-03 16:12 ` Bart Van Assche
2019-12-30 10:29 ` [PATCH v6 07/25] rtrs: client: statistics functions Jack Wang
2020-01-02 21:07 ` Bart Van Assche
2020-01-03 14:39 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 08/25] rtrs: client: sysfs interface functions Jack Wang
2020-01-02 21:14 ` Bart Van Assche
2020-01-03 14:59 ` Jinpu Wang [this message]
2019-12-30 10:29 ` [PATCH v6 09/25] rtrs: server: private header with server structs and functions Jack Wang
2020-01-02 21:24 ` Bart Van Assche
2020-01-08 16:33 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 10/25] rtrs: server: main functionality Jack Wang
2020-01-02 22:03 ` Bart Van Assche
2020-01-07 13:19 ` Jinpu Wang
2020-01-07 18:25 ` Jason Gunthorpe
2020-01-10 17:38 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 11/25] rtrs: server: statistics functions Jack Wang
2020-01-02 22:02 ` Bart Van Assche
2020-01-08 12:55 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 12/25] rtrs: server: sysfs interface functions Jack Wang
2020-01-02 22:06 ` Bart Van Assche
2020-01-07 14:40 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 13/25] rtrs: include client and server modules into kernel compilation Jack Wang
2020-01-02 22:11 ` Bart Van Assche
2020-01-03 16:19 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 14/25] rtrs: a bit of documentation Jack Wang
2019-12-30 23:19 ` Bart Van Assche
2020-01-07 14:48 ` Jinpu Wang
2020-01-02 22:21 ` Bart Van Assche
2020-01-07 15:49 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 15/25] rnbd: private headers with rnbd protocol structs and helpers Jack Wang
2020-01-02 22:34 ` Bart Van Assche
2020-01-07 16:53 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 16/25] rnbd: client: private header with client structs and functions Jack Wang
2020-01-02 22:37 ` Bart Van Assche
2020-01-07 17:09 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 17/25] rnbd: client: main functionality Jack Wang
2020-01-02 23:55 ` Bart Van Assche
2020-01-08 14:22 ` Jinpu Wang
2020-01-10 14:45 ` Jinpu Wang
2020-01-10 15:09 ` Roman Penyaev
2020-01-10 15:29 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 18/25] rnbd: client: sysfs interface functions Jack Wang
2020-01-03 0:03 ` Bart Van Assche
2020-01-08 13:06 ` Jinpu Wang
2020-01-08 16:39 ` Bart Van Assche
2020-01-08 16:51 ` Jinpu Wang
2019-12-30 10:29 ` [PATCH v6 19/25] rnbd: server: private header with server structs and functions Jack Wang
2019-12-30 10:29 ` [PATCH v6 20/25] rnbd: server: main functionality Jack Wang
2019-12-30 10:29 ` [PATCH v6 21/25] rnbd: server: functionality for IO submission to file or block dev Jack Wang
2019-12-30 10:29 ` [PATCH v6 22/25] rnbd: server: sysfs interface functions Jack Wang
2019-12-30 10:29 ` [PATCH v6 23/25] rnbd: include client and server modules into kernel compilation Jack Wang
2019-12-30 10:29 ` [PATCH v6 24/25] rnbd: a bit of documentation Jack Wang
2019-12-30 10:29 ` [PATCH v6 25/25] MAINTAINERS: Add maintainers for RNBD/RTRS modules Jack Wang
2019-12-30 12:22 ` Gal Pressman
2020-01-02 8:41 ` Jinpu Wang
2019-12-31 0:11 ` [PATCH v6 00/25] RTRS (former IBTRS) rdma transport library and RNBD (former IBNBD) rdma network block device Bart Van Assche
2020-01-02 8:48 ` Jinpu Wang
2019-12-31 2:39 ` Bart Van Assche
2020-01-02 9:20 ` Jinpu Wang
2020-01-02 18:28 ` Jason Gunthorpe
2020-01-03 12:34 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMGffEk+XSSdLU==O5inqEc2UycSaB7K1+vqkof=4RDnN4pp6Q@mail.gmail.com' \
--to=jinpu.wang@cloud.ionos.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=danil.kipnis@cloud.ionos.com \
--cc=dledford@redhat.com \
--cc=hch@infradead.org \
--cc=jinpuwang@gmail.com \
--cc=leon@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpenyaev@suse.de \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).