From: Greg KH <gregkh@linuxfoundation.org>
To: Haakon Bugge <haakon.bugge@oracle.com>
Cc: Sasha Levin <sashal@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Linux-Net <netdev@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
OFED mailing list <linux-rdma@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Guillaume Nault <gnault@redhat.com>
Subject: Re: Please add 2dce224f469f ("netns: protect netns ID lookups with RCU") to LTS
Date: Mon, 13 Sep 2021 10:42:45 +0200 [thread overview]
Message-ID: <YT8PBf0FiniWR0zm@kroah.com> (raw)
In-Reply-To: <756E20E4-399D-45ED-AA9A-BB351C865C65@oracle.com>
On Fri, Sep 10, 2021 at 02:22:32PM +0000, Haakon Bugge wrote:
>
>
> > On 9 Sep 2021, at 15:30, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Sep 09, 2021 at 01:10:05PM +0000, Haakon Bugge wrote:
> >> Hi Greg & Sasha,
> >>
> >>
> >> tl;dr: Please add 2dce224f469f ("netns: protect netns ID lookups with
> >> RCU") to the stable releases from v5.4 and older. It fixes a
> >> spin_unlock_bh() in peernet2id() called with IRQs off. I think this
> >> neat side-effect of commit 2dce224f469f was quite un-intentional,
> >> hence no Fixes: tag or CC: stable.
> >
> > Please provide a working backport for all of the relevant kernel
> > verisons, as it does not apply cleanly on it's own.
>
> I've done the backports. 4.9 is actually not needed, because it uses spin_{lock,unlock}_irqsave() in peernet2id(). Hence, we have an "offending" commit which this one fixes:
>
> fba143c66abb ("netns: avoid disabling irq for netns id")
>
> Will get'm out during the weekend.
All now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2021-09-13 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 13:10 Please add 2dce224f469f ("netns: protect netns ID lookups with RCU") to LTS Haakon Bugge
2021-09-09 13:30 ` Greg KH
2021-09-10 14:22 ` Haakon Bugge
2021-09-13 8:42 ` Greg KH [this message]
2021-09-14 8:58 ` Haakon Bugge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YT8PBf0FiniWR0zm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=gnault@redhat.com \
--cc=haakon.bugge@oracle.com \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).