From: Leon Romanovsky <leon@kernel.org>
To: Dave Ertman <david.m.ertman@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, yongxin.liu@windriver.com,
shiraz.saleem@intel.com, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jesse.brandeburg@intel.com, intel-wired-lan@lists.osuosl.org,
linux-rdma@vger.kernel.org, jgg@ziepe.ca
Subject: Re: [PATCH RESEND net] ice: Correctly deal with PFs that do not support RDMA
Date: Fri, 10 Sep 2021 12:19:10 +0300 [thread overview]
Message-ID: <YTsjDsFbBggL2X/8@unreal> (raw)
In-Reply-To: <20210909151223.572918-1-david.m.ertman@intel.com>
On Thu, Sep 09, 2021 at 08:12:23AM -0700, Dave Ertman wrote:
> There are two cases where the current PF does not support RDMA
> functionality. The first is if the NVM loaded on the device is set
> to not support RDMA (common_caps.rdma is false). The second is if
> the kernel bonding driver has included the current PF in an active
> link aggregate.
>
> When the driver has determined that this PF does not support RDMA, then
> auxiliary devices should not be created on the auxiliary bus.
This part is wrong, auxiliary devices should always be created, in your case it
will be one eth device only without extra irdma device.
Your "bug" is that you mixed auxiliary bus devices with "regular" ones
and created eth device not as auxiliary one. This is why you are calling
to auxiliary_device_init() for RDMA only and fallback to non-auxiliary mode.
I hope that this is simple mistake while Intel folks rushed to merge irdma
and not deliberate decision to find a way to support out-of-tree drivers.
As a reminder, the whole idea of auxiliary bus is to have small,
independent vendor driver core logic that manages capabilities and
based on that creates/removes sub-devices (eth, rdma, vdpa ...), so
driver core can properly load/unload their respective drivers.
Thanks
next prev parent reply other threads:[~2021-09-10 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 15:12 [PATCH RESEND net] ice: Correctly deal with PFs that do not support RDMA Dave Ertman
2021-09-10 9:19 ` Leon Romanovsky [this message]
2021-09-13 15:49 ` Saleem, Shiraz
2021-09-13 16:07 ` Ertman, David M
2021-09-14 3:16 ` Leon Romanovsky
2021-09-14 3:10 ` Leon Romanovsky
2021-09-24 14:10 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTsjDsFbBggL2X/8@unreal \
--to=leon@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
--cc=yongxin.liu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).