From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Konstantin Taranov <kotaranov@microsoft.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Long Li <longli@microsoft.com>,
Ajay Sharma <sharmaajay@microsoft.com>
Subject: Re: [PATCH v1 1/1] RDMA/mana_ib: Fix compilation error
Date: Fri, 26 Apr 2024 19:50:41 +0300 [thread overview]
Message-ID: <ZivbYdt2HxDpMxC5@smile.fi.intel.com> (raw)
In-Reply-To: <20240426163719.GA334984@nvidia.com>
On Fri, Apr 26, 2024 at 01:37:19PM -0300, Jason Gunthorpe wrote:
> On Tue, Apr 23, 2024 at 11:42:58PM +0300, Andy Shevchenko wrote:
> > The compilation with CONFIG_WERROR=y is broken:
> >
> > .../hw/mana/device.c:88:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> > if (!upper_ndev) {
> > ^~~~~~~~~~~
> >
> > Fix this by assigning the ret to -ENODEV in respective condition.
> >
> > Fixes: 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/infiniband/hw/mana/device.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> This was fixed in
Hmm... The below patch had been sent _after_ mine. What's wrong with mine patch?
> commit f88320b698ad099a2f742adfb9f87177bfffe0c5
> Author: Konstantin Taranov <kotaranov@microsoft.com>
> Date: Tue Apr 23 07:15:51 2024 -0700
>
> RDMA/mana_ib: Fix missing ret value
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-26 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 20:42 [PATCH v1 1/1] RDMA/mana_ib: Fix compilation error Andy Shevchenko
2024-04-23 23:58 ` Long Li
2024-04-26 16:37 ` Jason Gunthorpe
2024-04-26 16:50 ` Andy Shevchenko [this message]
2024-04-26 16:56 ` Andy Shevchenko
2024-04-26 16:58 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZivbYdt2HxDpMxC5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=kotaranov@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=sharmaajay@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).