From: "Liuyixian (Eason)" <liuyixian@huawei.com>
To: Leon Romanovsky <leon@kernel.org>, Parav Pandit <parav@mellanox.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linuxarm@huawei.com" <linuxarm@huawei.com>
Subject: Re: [PATCH rdma-next] RDMA/core: Use pr_warn_ratelimited
Date: Wed, 6 Nov 2019 10:15:15 +0800 [thread overview]
Message-ID: <bbad9230-b218-3054-ff10-650ceaa0f7c3@huawei.com> (raw)
In-Reply-To: <20191105144103.GF6763@unreal>
On 2019/11/5 22:41, Leon Romanovsky wrote:
> On Tue, Nov 05, 2019 at 04:09:12AM +0000, Parav Pandit wrote:
>> Hi Yixian Liu,
>>
>>> -----Original Message-----
>>> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
>>> owner@vger.kernel.org> On Behalf Of Yixian Liu
>>> Sent: Monday, November 4, 2019 9:48 PM
>>> To: dledford@redhat.com; jgg@ziepe.ca
>>> Cc: Parav Pandit <parav@mellanox.com>; leon@kernel.org; linux-
>>> rdma@vger.kernel.org; linuxarm@huawei.com
>>> Subject: [PATCH rdma-next] RDMA/core: Use pr_warn_ratelimited
>>>
>>> This warning can be triggered easily when adding a large number of VLANs
>>> while the capacity of GID table is small.
>>>
>>> Fixes: 598ff6bae689 ("IB/core: Refactor GID modify code for RoCE")
>>> Signed-off-by: Yixian Liu <liuyixian@huawei.com>
>>> ---
>>> drivers/infiniband/core/cache.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>> Thanks for the patch. However, vlan netdevice addition is an administrative operation allowed to process which has CAP_NET_ADMIN privilege.
>> So large number of VLAN addition by a user for a RoCE device whose GID capacity is small is constrained operation.
>> Therefore, we shouldn't be rate limiting it.
>> By rate limiting we miss the information about any bugs in GID cache management.
>> At best we can convert it to dev_dbg() so that we still get the necessary debug information when needed.
>> I wanted to convert them trace functions which will allow us to more debug level prints such as netdev name, vlan etc.
>> I think I remember comment from Leon too while working on it, but it was long haul that time.
>
> I wanted to work on it, but it never happened.
I see, thanks.
>
> Thanks
>
> .
>
prev parent reply other threads:[~2019-11-06 2:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 3:48 [PATCH rdma-next] RDMA/core: Use pr_warn_ratelimited Yixian Liu
2019-11-05 4:09 ` Parav Pandit
2019-11-05 7:55 ` Liuyixian (Eason)
2019-11-05 15:02 ` Parav Pandit
2019-11-06 2:15 ` Liuyixian (Eason)
2019-11-05 14:41 ` Leon Romanovsky
2019-11-06 2:15 ` Liuyixian (Eason) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbad9230-b218-3054-ff10-650ceaa0f7c3@huawei.com \
--to=liuyixian@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).