From: Max Gurtovoy <maxg@mellanox.com>
To: Alexey Lyashkov <umka@cloudlinux.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Leon Romanovsky <leon@kernel.org>,
Israel Rukshin <israelr@mellanox.com>,
sagi@grimberg.me, jgg@mellanox.com, linux-rdma@vger.kernel.org,
dledford@redhat.com, sergeygo@mellanox.com
Subject: Re: [PATCH] IB/iser: Remove support for FMR memory registration
Date: Thu, 14 May 2020 13:50:48 +0300 [thread overview]
Message-ID: <f6d970e6-2373-e070-40fb-9db82c136e4b@mellanox.com> (raw)
In-Reply-To: <0C22D41B-89CD-4B2D-B514-8EA06F2233D7@cloudlinux.com>
On 5/14/2020 1:09 PM, Alexey Lyashkov wrote:
> CX3 with fast registration isn’t stable enough.
> I was make this change for Lustre for year or two ago, but it was
> reverted by serious bugs.
>
I'm not aware of any issues there.
You can always report it on the mailing list.
> Alex
>> 13 мая 2020 г., в 11:43, Max Gurtovoy <maxg@mellanox.com
>> <mailto:maxg@mellanox.com>> написал(а):
>>
>>
>> On 5/12/2020 11:09 PM, Bart Van Assche wrote:
>>> On 2020-05-12 10:16, Leon Romanovsky wrote:
>>>> On Tue, May 12, 2020 at 07:08:59PM +0300, Israel Rukshin wrote:
>>>>> FMR is not supported on most recent RDMA devices (that use fast memory
>>>>> registration mechanism). Also, FMR was recently removed from NFS/RDMA
>>>>> ULP.
>>>>>
>>>>> Signed-off-by: Israel Rukshin <israelr@mellanox.com
>>>>> <mailto:israelr@mellanox.com>>
>>>>> Signed-off-by: Max Gurtovoy <maxg@mellanox.com
>>>>> <mailto:maxg@mellanox.com>>
>>>>> ---
>>>>> drivers/infiniband/ulp/iser/iscsi_iser.h | 79 +----------
>>>>> drivers/infiniband/ulp/iser/iser_initiator.c | 19 ++-
>>>>> drivers/infiniband/ulp/iser/iser_memory.c | 188
>>>>> ++-------------------------
>>>>> drivers/infiniband/ulp/iser/iser_verbs.c | 126 +++---------------
>>>>> 4 files changed, 40 insertions(+), 372 deletions(-)
>>>> Can we do an extra step and remove FMR from srp too?
>>> Which HCA's will be affected by removing FMR support? Or in other words,
>>> when did (Mellanox) HCA's start supporting fast memory registration? I'm
>>> asking this because there is a tradition in the Linux kernel not to
>>> remove support for old hardware unless it is pretty sure that nobody is
>>> using that hardware anymore.
>>
>> ConnectX-3 and above supports fast memory registrations.
>>
>>
>>>
>>> Thanks,
>>>
>>> Bart.
>
next prev parent reply other threads:[~2020-05-14 10:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 16:08 [PATCH] IB/iser: Remove support for FMR memory registration Israel Rukshin
2020-05-12 17:16 ` Leon Romanovsky
2020-05-12 17:53 ` Max Gurtovoy
2020-05-12 20:09 ` Bart Van Assche
2020-05-12 20:13 ` Jason Gunthorpe
2020-05-12 20:27 ` Bart Van Assche
2020-05-12 23:06 ` Jason Gunthorpe
2020-05-13 0:53 ` Sagi Grimberg
2020-05-13 7:18 ` Leon Romanovsky
2020-05-13 16:44 ` Dennis Dalessandro
2020-05-13 18:43 ` Leon Romanovsky
2020-05-13 19:49 ` Bart Van Assche
2020-05-13 8:43 ` Max Gurtovoy
2020-05-13 11:29 ` Tom Talpey
[not found] ` <0C22D41B-89CD-4B2D-B514-8EA06F2233D7@cloudlinux.com>
2020-05-14 10:50 ` Max Gurtovoy [this message]
2020-05-14 13:50 ` Tom Talpey
2020-05-17 8:35 ` Sagi Grimberg
2020-05-17 14:55 ` Alexey Lyashkov
2020-05-18 7:16 ` Christoph Hellwig
2020-05-13 0:56 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6d970e6-2373-e070-40fb-9db82c136e4b@mellanox.com \
--to=maxg@mellanox.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=israelr@mellanox.com \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=sergeygo@mellanox.com \
--cc=umka@cloudlinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).