Re: [PATCH for-next V4 0/4] RDMA: Cleanups and improvements

From: Doug Ledford <dledford@redhat.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Kamal Heib <kamalheib1@gmail.com>,
	linux-rdma@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
	Potnuri Bharat Teja <bharat@chelsio.com>,
	Selvin Xavier <selvin.xavier@broadcom.com>,
	Gal Pressman <galpress@amazon.com>,
	Michal Kalderon <mkalderon@marvell.com>,
	Christian Benvenuti <benve@cisco.com>,
	Moni Shoua <monis@mellanox.com>,
	Bernard Metzler <bmt@zurich.ibm.com>,
	Shiraz Saleem <shiraz.saleem@intel.com>,
	Andrew Boyer <aboyer@tobark.org>
Subject: Re: [PATCH for-next V4 0/4] RDMA: Cleanups and improvements
Date: Thu, 08 Aug 2019 16:38:19 -0400	[thread overview]
Message-ID: <feab2a069bf9ac1e3c627373add292a77db86be0.camel@redhat.com> (raw)
In-Reply-To: <20190808075441.GA28049@mtr-leonro.mtl.com>

[-- Attachment #1: Type: text/plain, Size: 1966 bytes --]

On Thu, 2019-08-08 at 10:54 +0300, Leon Romanovsky wrote:
> On Wed, Aug 07, 2019 at 03:56:26PM -0400, Doug Ledford wrote:
> > On Wed, 2019-08-07 at 13:31 +0300, Kamal Heib wrote:
> > > This series includes few cleanups and improvements, the first
> > > patch
> > > introduce a new enum for describing the physical state values and
> > > use
> > > it
> > > instead of using the magic numbers, patch 2-4 add support for a
> > > common
> > > query port for iWARP drivers and remove the common code from the
> > > iWARP
> > > drivers.
> > > 
> > > Changes from v3:
> > > - Patch #1:
> > > -- Introduce phys_state_to_str() and use it.
> > > 
> > > Changes from v2:
> > > - Patch #1:
> > > -- Update mlx4 and hns to use the new ib_port_phys_state enum.
> > > - Patch #3:
> > > -- Use rdma_protocol_iwarp() instead of rdma_node_get_transport().
> > > 
> > > Changes from v1 :
> > > - Patch #3:
> > > -- Delete __ prefix.
> > > -- Add missing dev_put(netdev);
> > > -- Initilize gid to {}.
> > > -- Return error code directly.
> > > 
> > > Kamal Heib (4):
> > >   RDMA: Introduce ib_port_phys_state enum
> > >   RDMA/cxgb3: Use ib_device_set_netdev()
> > >   RDMA/core: Add common iWARP query port
> > >   RDMA/{cxgb3, cxgb4, i40iw}: Remove common code
> > 
> > Thanks, series applied to for-next.
> 
> Doug,
> 
> First patch is not accurate and need to be reworked/discussed.
> 
> first, it changed "Phy Test" output to be "PhyTest" and second
> "<unknown>" was changed to be "Unknown". I don't think that it is a
> big
> deal, but who knows what will break after this change.

A quick grep -r of rdma-core for "Phy Test" and "unknown" says nothing
will break, but that doesn't attest to anything else.

It is also still in my wip branch, so can be fixed directly if needed.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]