From: Md Danish Anwar <a0501179@ti.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
MD Danish Anwar <danishanwar@ti.com>
Cc: "Andrew F. Davis" <afd@ti.com>, Suman Anna <s-anna@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Nishanth Menon <nm@ti.com>, <linux-remoteproc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<srk@ti.com>, <devicetree@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v5 5/5] soc: ti: pruss: Add helper functions to get/set PRUSS_CFG_GPMUX
Date: Tue, 28 Mar 2023 16:58:26 +0530 [thread overview]
Message-ID: <08cdd2b7-5152-8dec-aea2-ce286f8b97fb@ti.com> (raw)
In-Reply-To: <20230327210429.GD3158115@p14s>
On 28/03/23 02:34, Mathieu Poirier wrote:
> On Thu, Mar 23, 2023 at 11:54:51AM +0530, MD Danish Anwar wrote:
>> From: Tero Kristo <t-kristo@ti.com>
>>
>> Add two new helper functions pruss_cfg_get_gpmux() & pruss_cfg_set_gpmux()
>> to get and set the GP MUX mode for programming the PRUSS internal wrapper
>> mux functionality as needed by usecases.
>>
>> Co-developed-by: Suman Anna <s-anna@ti.com>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>> Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
>> Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
>> Signed-off-by: Puranjay Mohan <p-mohan@ti.com>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> Reviewed-by: Roger Quadros <rogerq@kernel.org>
>> ---
>> drivers/soc/ti/pruss.c | 44 ++++++++++++++++++++++++++++++++
>> include/linux/remoteproc/pruss.h | 30 ++++++++++++++++++++++
>> 2 files changed, 74 insertions(+)
>>
>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
>> index ac415442e85b..3aa3c38c6c79 100644
>> --- a/drivers/soc/ti/pruss.c
>> +++ b/drivers/soc/ti/pruss.c
>> @@ -239,6 +239,50 @@ int pruss_cfg_xfr_enable(struct pruss *pruss, enum pru_type pru_type,
>> }
>> EXPORT_SYMBOL_GPL(pruss_cfg_xfr_enable);
>>
>> +/**
>> + * pruss_cfg_get_gpmux() - get the current GPMUX value for a PRU device
>> + * @pruss: pruss instance
>> + * @pru_id: PRU identifier (0-1)
>> + * @mux: pointer to store the current mux value into
>> + *
>> + * Return: 0 on success, or an error code otherwise
>> + */
>> +int pruss_cfg_get_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 *mux)
>> +{
>> + int ret = 0;
>> + u32 val;
>> +
>> + if (pru_id < 0 || pru_id >= PRUSS_NUM_PRUS)
>> + return -EINVAL;
>> +
>> + ret = pruss_cfg_read(pruss, PRUSS_CFG_GPCFG(pru_id), &val);
>> + if (!ret)
>> + *mux = (u8)((val & PRUSS_GPCFG_PRU_MUX_SEL_MASK) >>
>> + PRUSS_GPCFG_PRU_MUX_SEL_SHIFT);
>
> What happens if @mux is NULL?
@mux being null may result in some error here. I will add NULL check for mux
before storing the value in mux.
I will modify the above if condition to have NULL check for mux as well.
The if condition will look like below.
if (pru_id < 0 || pru_id >= PRUSS_NUM_PRUS || !mux)
return -EINVAL;
Please let me know if this looks OK.
>
> Thanks,
> Mathieu
>
>
>> + return ret;
>> +}
>> +EXPORT_SYMBOL_GPL(pruss_cfg_get_gpmux);
>> +
>> +/**
>> + * pruss_cfg_set_gpmux() - set the GPMUX value for a PRU device
>> + * @pruss: pruss instance
>> + * @pru_id: PRU identifier (0-1)
>> + * @mux: new mux value for PRU
>> + *
>> + * Return: 0 on success, or an error code otherwise
>> + */
>> +int pruss_cfg_set_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 mux)
>> +{
>> + if (mux >= PRUSS_GP_MUX_SEL_MAX ||
>> + pru_id < 0 || pru_id >= PRUSS_NUM_PRUS)
>> + return -EINVAL;
>> +
>> + return pruss_cfg_update(pruss, PRUSS_CFG_GPCFG(pru_id),
>> + PRUSS_GPCFG_PRU_MUX_SEL_MASK,
>> + (u32)mux << PRUSS_GPCFG_PRU_MUX_SEL_SHIFT);
>> +}
>> +EXPORT_SYMBOL_GPL(pruss_cfg_set_gpmux);
>> +
>> static void pruss_of_free_clk_provider(void *data)
>> {
>> struct device_node *clk_mux_np = data;
>> diff --git a/include/linux/remoteproc/pruss.h b/include/linux/remoteproc/pruss.h
>> index bb001f712980..42f1586c62ac 100644
>> --- a/include/linux/remoteproc/pruss.h
>> +++ b/include/linux/remoteproc/pruss.h
>> @@ -16,6 +16,24 @@
>>
>> #define PRU_RPROC_DRVNAME "pru-rproc"
>>
>> +/*
>> + * enum pruss_gp_mux_sel - PRUSS GPI/O Mux modes for the
>> + * PRUSS_GPCFG0/1 registers
>> + *
>> + * NOTE: The below defines are the most common values, but there
>> + * are some exceptions like on 66AK2G, where the RESERVED and MII2
>> + * values are interchanged. Also, this bit-field does not exist on
>> + * AM335x SoCs
>> + */
>> +enum pruss_gp_mux_sel {
>> + PRUSS_GP_MUX_SEL_GP = 0,
>> + PRUSS_GP_MUX_SEL_ENDAT,
>> + PRUSS_GP_MUX_SEL_RESERVED,
>> + PRUSS_GP_MUX_SEL_SD,
>> + PRUSS_GP_MUX_SEL_MII2,
>> + PRUSS_GP_MUX_SEL_MAX,
>> +};
>> +
>> /*
>> * enum pruss_gpi_mode - PRUSS GPI configuration modes, used
>> * to program the PRUSS_GPCFG0/1 registers
>> @@ -110,6 +128,8 @@ int pruss_cfg_gpimode(struct pruss *pruss, enum pruss_pru_id pru_id,
>> int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable);
>> int pruss_cfg_xfr_enable(struct pruss *pruss, enum pru_type pru_type,
>> bool enable);
>> +int pruss_cfg_get_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 *mux);
>> +int pruss_cfg_set_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 mux);
>>
>> #else
>>
>> @@ -152,6 +172,16 @@ static inline int pruss_cfg_xfr_enable(struct pruss *pruss,
>> return ERR_PTR(-EOPNOTSUPP);
>> }
>>
>> +static inline int pruss_cfg_get_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 *mux)
>> +{
>> + return ERR_PTR(-EOPNOTSUPP);
>> +}
>> +
>> +static inline int pruss_cfg_set_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 mux)
>> +{
>> + return ERR_PTR(-EOPNOTSUPP);
>> +}
>> +
>> #endif /* CONFIG_TI_PRUSS */
>>
>> #if IS_ENABLED(CONFIG_PRU_REMOTEPROC)
>> --
>> 2.25.1
>>
--
Thanks and Regards,
Danish.
next prev parent reply other threads:[~2023-03-28 11:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 6:24 [PATCH v5 0/5] Introduce PRU platform consumer API MD Danish Anwar
2023-03-23 6:24 ` [PATCH v5 1/5] soc: ti: pruss: Add pruss_get()/put() API MD Danish Anwar
2023-03-27 20:58 ` Mathieu Poirier
2023-03-28 5:42 ` [EXTERNAL] " Md Danish Anwar
2023-03-29 17:59 ` Mathieu Poirier
2023-03-30 9:16 ` Md Danish Anwar
2023-03-23 6:24 ` [PATCH v5 2/5] soc: ti: pruss: Add pruss_{request,release}_mem_region() API MD Danish Anwar
2023-03-27 20:59 ` Mathieu Poirier
2023-03-23 6:24 ` [PATCH v5 3/5] soc: ti: pruss: Add pruss_cfg_read()/update() API MD Danish Anwar
2023-03-23 9:30 ` Roger Quadros
2023-03-27 21:01 ` Mathieu Poirier
2023-03-28 11:17 ` [EXTERNAL] " Md Danish Anwar
2023-03-30 10:00 ` Md Danish Anwar
2023-03-30 14:21 ` Mathieu Poirier
2023-03-31 10:22 ` Md Danish Anwar
2023-03-31 11:34 ` Md Danish Anwar
2023-03-30 15:06 ` Roger Quadros
2023-03-23 6:24 ` [PATCH v5 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR MD Danish Anwar
2023-03-23 9:32 ` Roger Quadros
2023-03-23 6:24 ` [PATCH v5 5/5] soc: ti: pruss: Add helper functions to get/set PRUSS_CFG_GPMUX MD Danish Anwar
2023-03-27 21:04 ` Mathieu Poirier
2023-03-28 11:28 ` Md Danish Anwar [this message]
2023-03-29 18:04 ` [EXTERNAL] " Mathieu Poirier
2023-03-30 9:18 ` Md Danish Anwar
2023-03-23 7:00 ` [PATCH v5 0/5] Introduce PRU platform consumer API Tony Lindgren
2023-03-24 7:13 ` Md Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08cdd2b7-5152-8dec-aea2-ce286f8b97fb@ti.com \
--to=a0501179@ti.com \
--cc=afd@ti.com \
--cc=andersson@kernel.org \
--cc=danishanwar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=rogerq@kernel.org \
--cc=s-anna@ti.com \
--cc=srk@ti.com \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).