Re: [PATCH v2 2/3] remoteproc: imx_rproc: mailbox support

From: kbuild test robot <lkp@intel.com>
To: nikita.shubin@maquefel.me
Cc: kbuild-all@lists.01.org, Ohad Ben-Cohen <ohad@wizery.com>,
	Fabio Estevam <festevam@gmail.com>,
	Nikita Shubin <NShubin@topcon.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] remoteproc: imx_rproc: mailbox support
Date: Tue, 7 Apr 2020 09:07:44 +0800	[thread overview]
Message-ID: <202004070942.cvfQ8cuj%lkp@intel.com> (raw)
In-Reply-To: <20200406113310.3041-3-nikita.shubin@maquefel.me>

[-- Attachment #1: Type: text/plain, Size: 3482 bytes --]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on v5.6 next-20200406]
[cannot apply to linus/master remoteproc/for-next rpmsg/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/nikita-shubin-maquefel-me/remoteproc-imx_rproc-add-virtio-support/20200406-201717
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f5ae2ea6347a308cfe91f53b53682ce635497d0d
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:331,
                    from include/linux/kernel.h:15,
                    from include/linux/clk.h:13,
                    from drivers/remoteproc/imx_rproc.c:6:
   drivers/remoteproc/imx_rproc.c: In function 'imx_rproc_free_mbox':
>> drivers/remoteproc/imx_rproc.c:347:23: warning: format '%d' expects argument of type 'int', but argument 5 has type 'long unsigned int' [-Wformat=]
     347 |  dev_dbg(&rproc->dev, "%s: %d boxes\n",
         |                       ^~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
     125 |   func(&id, ##__VA_ARGS__);  \
         |               ^~~~~~~~~~~
   include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
     157 |  _dynamic_func_call(fmt,__dynamic_dev_dbg,   \
         |  ^~~~~~~~~~~~~~~~~~
   include/linux/device.h:1784:2: note: in expansion of macro 'dynamic_dev_dbg'
    1784 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |  ^~~~~~~~~~~~~~~
   include/linux/device.h:1784:23: note: in expansion of macro 'dev_fmt'
    1784 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                       ^~~~~~~
>> drivers/remoteproc/imx_rproc.c:347:2: note: in expansion of macro 'dev_dbg'
     347 |  dev_dbg(&rproc->dev, "%s: %d boxes\n",
         |  ^~~~~~~
   drivers/remoteproc/imx_rproc.c:347:29: note: format string is defined here
     347 |  dev_dbg(&rproc->dev, "%s: %d boxes\n",
         |                            ~^
         |                             |
         |                             int
         |                            %ld

vim +347 drivers/remoteproc/imx_rproc.c

   341	
   342	static void imx_rproc_free_mbox(struct rproc *rproc)
   343	{
   344		struct imx_rproc *ddata = rproc->priv;
   345		unsigned int i;
   346	
 > 347		dev_dbg(&rproc->dev, "%s: %d boxes\n",
   348			__func__, ARRAY_SIZE(ddata->mb));
   349	
   350		for (i = 0; i < ARRAY_SIZE(ddata->mb); i++) {
   351			if (ddata->mb[i].chan)
   352				mbox_free_channel(ddata->mb[i].chan);
   353			ddata->mb[i].chan = NULL;
   354		}
   355	}
   356	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69606 bytes --]