From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
Cc: bjorn.andersson@linaro.org, ohad@wizery.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
loic.pallardy@st.com, linux-remoteproc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/12] remoteproc: stm32: Decouple rproc from DT parsing
Date: Thu, 30 Apr 2020 14:58:19 -0600 [thread overview]
Message-ID: <20200430205819.GD18004@xps15> (raw)
In-Reply-To: <b68419a6-65a9-08d0-bed8-5f8195ae3d55@st.com>
On Wed, Apr 29, 2020 at 03:37:58PM +0200, Arnaud POULIQUEN wrote:
> Hi Mathieu,
>
> On 4/24/20 10:24 PM, Mathieu Poirier wrote:
> > Remove the remote processor from the process of parsing the device tree
> > since (1) there is no correlation between them and (2) to use the
> > information that was gathered to make a decision on whether to
> > synchronise with the M4 or not.
> >
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > ---
> > drivers/remoteproc/stm32_rproc.c | 25 ++++++++++++++-----------
> > 1 file changed, 14 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> > index 1ac90adba9b1..57a426ea620b 100644
> > --- a/drivers/remoteproc/stm32_rproc.c
> > +++ b/drivers/remoteproc/stm32_rproc.c
> > @@ -538,12 +538,11 @@ static int stm32_rproc_get_syscon(struct device_node *np, const char *prop,
> > return err;
> > }
> >
> > -static int stm32_rproc_parse_dt(struct platform_device *pdev)
> > +static int stm32_rproc_parse_dt(struct platform_device *pdev,
> > + struct stm32_rproc *ddata, bool *auto_boot)
> > {
> > struct device *dev = &pdev->dev;
> > struct device_node *np = dev->of_node;
> > - struct rproc *rproc = platform_get_drvdata(pdev);
> > - struct stm32_rproc *ddata = rproc->priv;
> > struct stm32_syscon tz;
> > unsigned int tzen;
> > int err, irq;
> > @@ -589,7 +588,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev)
> >
> > err = regmap_read(tz.map, tz.reg, &tzen);
> > if (err) {
> > - dev_err(&rproc->dev, "failed to read tzen\n");
> > + dev_err(dev, "failed to read tzen\n");
> > return err;
> > }
> > ddata->secured_soc = tzen & tz.mask;
> > @@ -605,7 +604,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev)
> > if (err)
> > dev_info(dev, "failed to get pdds\n");
> >
> > - rproc->auto_boot = of_property_read_bool(np, "st,auto-boot");
> > + *auto_boot = of_property_read_bool(np, "st,auto-boot");
> >
> > return stm32_rproc_of_memory_translations(pdev, ddata);
> > }
> > @@ -616,6 +615,7 @@ static int stm32_rproc_probe(struct platform_device *pdev)
> > struct stm32_rproc *ddata;
> > struct device_node *np = dev->of_node;
> > struct rproc *rproc;
> > + bool auto_boot = false;
>
> Nitpicking: Seems that you don't need to initialize it.
I think you are correct.
> Perhaps you can simply suppress the local variable and directly use rproc->auto_boot.
... and change the value of rproc->auto_boot if state == M4_STATE_CRUN? Sure,
that's possible.
Thanks for all the comments, it really helps to have a different perspective. I
am out of time for today but will continue with the rest of your comments
tomorrow.
Mathieu
>
> else LGTM
>
>
> Thanks,
> Arnaud
>
> > int ret;
> >
> > ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32));
> > @@ -626,9 +626,16 @@ static int stm32_rproc_probe(struct platform_device *pdev)
> > if (!rproc)
> > return -ENOMEM;
> >
> > + ddata = rproc->priv;
> > +
> > rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_NONE);
> > +
> > + ret = stm32_rproc_parse_dt(pdev, ddata, &auto_boot);
> > + if (ret)
> > + goto free_rproc;
> > +
> > + rproc->auto_boot = auto_boot;
> > rproc->has_iommu = false;
> > - ddata = rproc->priv;
> > ddata->workqueue = create_workqueue(dev_name(dev));
> > if (!ddata->workqueue) {
> > dev_err(dev, "cannot create workqueue\n");
> > @@ -638,13 +645,9 @@ static int stm32_rproc_probe(struct platform_device *pdev)
> >
> > platform_set_drvdata(pdev, rproc);
> >
> > - ret = stm32_rproc_parse_dt(pdev);
> > - if (ret)
> > - goto free_wkq;
> > -
> > ret = stm32_rproc_request_mbox(rproc);
> > if (ret)
> > - goto free_rproc;
> > + goto free_wkq;
> >
> > ret = rproc_add(rproc);
> > if (ret)
> >
next prev parent reply other threads:[~2020-04-30 20:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 20:24 [PATCH v2 00/12] remoteproc: stm32: Add support for synchronising with M4 Mathieu Poirier
2020-04-24 20:24 ` [PATCH v2 01/12] remoteproc: stm32: Decouple rproc from memory translation Mathieu Poirier
2020-05-14 4:57 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 02/12] remoteproc: stm32: Request IRQ with platform device Mathieu Poirier
2020-05-14 4:57 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 03/12] remoteproc: stm32: Decouple rproc from DT parsing Mathieu Poirier
2020-04-29 13:37 ` Arnaud POULIQUEN
2020-04-30 20:58 ` Mathieu Poirier [this message]
2020-05-14 4:59 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 04/12] remoteproc: stm32: Remove memory translation " Mathieu Poirier
2020-05-14 5:03 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 05/12] remoteproc: stm32: Parse syscon that will manage M4 synchronisation Mathieu Poirier
2020-05-14 5:03 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 06/12] remoteproc: stm32: Get coprocessor state Mathieu Poirier
2020-04-29 13:38 ` Arnaud POULIQUEN
2020-05-01 17:40 ` Mathieu Poirier
2020-04-24 20:25 ` [PATCH v2 07/12] remoteproc: stm32: Get loaded resource table for synchronisation Mathieu Poirier
2020-04-24 20:25 ` [PATCH v2 08/12] remoteproc: stm32: Introduce new start ops " Mathieu Poirier
2020-04-29 14:50 ` Arnaud POULIQUEN
2020-04-24 20:25 ` [PATCH v2 09/12] remoteproc: stm32: Update M4 state in stm32_rproc_stop() Mathieu Poirier
2020-04-29 14:52 ` Arnaud POULIQUEN
2020-04-24 20:25 ` [PATCH v2 10/12] remoteproc: stm32: Introduce new parse fw ops for synchronisation Mathieu Poirier
2020-05-14 5:13 ` Bjorn Andersson
2020-04-24 20:25 ` [PATCH v2 11/12] remoteproc: stm32: Introduce new loaded rsc " Mathieu Poirier
2020-05-14 5:15 ` Bjorn Andersson
2020-04-24 20:25 ` [PATCH v2 12/12] remoteproc: stm32: Set synchronisation state machine if needed Mathieu Poirier
2020-04-29 14:47 ` Arnaud POULIQUEN
2020-05-01 17:54 ` Mathieu Poirier
2020-04-29 15:08 ` [PATCH v2 00/12] remoteproc: stm32: Add support for synchronising with M4 Arnaud POULIQUEN
2020-05-01 17:59 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430205819.GD18004@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=loic.pallardy@st.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).