From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
virtualization@lists.linux-foundation.org,
sound-open-firmware@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jason Wang <jasowang@redhat.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH v3 0/5] Add a vhost RPMsg API
Date: Fri, 5 Jun 2020 08:34:35 +0200 [thread overview]
Message-ID: <20200605063435.GA32302@ubuntu> (raw)
In-Reply-To: <20200604151917-mutt-send-email-mst@kernel.org>
Hi Michael,
Thanks for your review.
On Thu, Jun 04, 2020 at 03:23:37PM -0400, Michael S. Tsirkin wrote:
> On Wed, May 27, 2020 at 08:05:36PM +0200, Guennadi Liakhovetski wrote:
> > v3:
> > - address several checkpatch warnings
> > - address comments from Mathieu Poirier
> >
> > v2:
> > - update patch #5 with a correct vhost_dev_init() prototype
> > - drop patch #6 - it depends on a different patch, that is currently
> > an RFC
> > - address comments from Pierre-Louis Bossart:
> > * remove "default n" from Kconfig
> >
> > Linux supports RPMsg over VirtIO for "remote processor" /AMP use
> > cases. It can however also be used for virtualisation scenarios,
> > e.g. when using KVM to run Linux on both the host and the guests.
> > This patch set adds a wrapper API to facilitate writing vhost
> > drivers for such RPMsg-based solutions. The first use case is an
> > audio DSP virtualisation project, currently under development, ready
> > for review and submission, available at
> > https://github.com/thesofproject/linux/pull/1501/commits
> > A further patch for the ADSP vhost RPMsg driver will be sent
> > separately for review only since it cannot be merged without audio
> > patches being upstreamed first.
>
>
> RPMsg over virtio has several problems. One is that it's
> not specced at all. Before we add more stuff, I'd like so
> see at least an attempt at describing what it's supposed to do.
Sure, I can work on this with the original authors of the virtio-rpmsg
implementation.
> Another it's out of line with 1.0 spec passing guest
> endian data around. Won't work if host and guest
> endian-ness do not match. Should pass eveything in LE and
> convert.
Yes, I have to fix this, thanks.
> It's great to see it's seeing active development finally.
> Do you think you will have time to address these?
Sure, I'll try to take care of them.
Thanks
Guennadi
> > Guennadi Liakhovetski (5):
> > vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl
> > vhost: (cosmetic) remove a superfluous variable initialisation
> > rpmsg: move common structures and defines to headers
> > rpmsg: update documentation
> > vhost: add an RPMsg API
> >
> > Documentation/rpmsg.txt | 6 +-
> > drivers/rpmsg/virtio_rpmsg_bus.c | 78 +-------
> > drivers/vhost/Kconfig | 7 +
> > drivers/vhost/Makefile | 3 +
> > drivers/vhost/rpmsg.c | 382 +++++++++++++++++++++++++++++++++++++++
> > drivers/vhost/vhost.c | 2 +-
> > drivers/vhost/vhost_rpmsg.h | 74 ++++++++
> > include/linux/virtio_rpmsg.h | 81 +++++++++
> > include/uapi/linux/rpmsg.h | 3 +
> > include/uapi/linux/vhost.h | 4 +-
> > 10 files changed, 559 insertions(+), 81 deletions(-)
> > create mode 100644 drivers/vhost/rpmsg.c
> > create mode 100644 drivers/vhost/vhost_rpmsg.h
> > create mode 100644 include/linux/virtio_rpmsg.h
> >
> > --
> > 1.9.3
>
next prev parent reply other threads:[~2020-06-05 6:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 18:05 [PATCH v3 0/5] Add a vhost RPMsg API Guennadi Liakhovetski
2020-05-27 18:05 ` [PATCH v3 1/5] vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl Guennadi Liakhovetski
2020-05-27 18:05 ` [PATCH v3 2/5] vhost: (cosmetic) remove a superfluous variable initialisation Guennadi Liakhovetski
2020-05-27 18:05 ` [PATCH v3 3/5] rpmsg: move common structures and defines to headers Guennadi Liakhovetski
2020-05-27 18:05 ` [PATCH v3 4/5] rpmsg: update documentation Guennadi Liakhovetski
2020-05-28 19:26 ` Mathieu Poirier
2020-05-27 18:05 ` [PATCH v3 5/5] vhost: add an RPMsg API Guennadi Liakhovetski
2020-05-28 19:26 ` Mathieu Poirier
2020-06-17 19:17 ` Vincent Whitchurch
2020-06-18 9:03 ` Guennadi Liakhovetski
2020-06-18 9:33 ` Vincent Whitchurch
2020-06-18 10:39 ` Guennadi Liakhovetski
2020-06-18 13:52 ` Vincent Whitchurch
2020-06-18 14:14 ` Guennadi Liakhovetski
2020-07-14 8:33 ` Vincent Whitchurch
2020-05-29 6:01 ` [PATCH v3 0/5] Add a vhost " Jason Wang
2020-05-29 6:50 ` Guennadi Liakhovetski
2020-05-29 7:06 ` Jason Wang
2020-06-04 19:23 ` Michael S. Tsirkin
2020-06-05 6:34 ` Guennadi Liakhovetski [this message]
2020-06-08 7:37 ` Guennadi Liakhovetski
2020-06-08 9:09 ` Michael S. Tsirkin
2020-06-08 9:11 ` Guennadi Liakhovetski
2020-06-08 9:19 ` Michael S. Tsirkin
2020-06-08 10:15 ` Guennadi Liakhovetski
2020-06-08 11:16 ` Guennadi Liakhovetski
2020-06-08 13:08 ` Michael S. Tsirkin
2020-06-08 13:01 ` Michael S. Tsirkin
2020-06-05 10:01 ` [Sound-open-firmware] " Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605063435.GA32302@ubuntu \
--to=guennadi.liakhovetski@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=ohad@wizery.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).