Re: [PATCH v4 1/4] remoteproc: imx_rproc: Move common structure to header file

From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, daniel.baluta@nxp.com,
	linux-imx@nxp.com, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, shengjiu.wang@gmail.com
Subject: Re: [PATCH v4 1/4] remoteproc: imx_rproc: Move common structure to header file
Date: Tue, 14 Sep 2021 11:46:39 -0600	[thread overview]
Message-ID: <20210914174639.GB1719994@p14s> (raw)
In-Reply-To: <1631092255-25150-2-git-send-email-shengjiu.wang@nxp.com>

On Wed, Sep 08, 2021 at 05:10:52PM +0800, Shengjiu Wang wrote:
> Move common structure imx_rproc_att, imx_rproc_method
> and imx_rproc_dcfg to header file which can be shared with
> imx_dsp_rproc driver.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  drivers/remoteproc/imx_rproc.c | 28 +------------------------
>  drivers/remoteproc/imx_rproc.h | 37 ++++++++++++++++++++++++++++++++++
>  2 files changed, 38 insertions(+), 27 deletions(-)
>  create mode 100644 drivers/remoteproc/imx_rproc.h
> 

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index d88f76f5305e..b0da0130c3b6 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -19,6 +19,7 @@
>  #include <linux/remoteproc.h>
>  #include <linux/workqueue.h>
>  
> +#include "imx_rproc.h"
>  #include "remoteproc_internal.h"
>  
>  #define IMX7D_SRC_SCR			0x0C
> @@ -72,33 +73,6 @@ struct imx_rproc_mem {
>  /* M4 own area. Can be mapped at probe */
>  #define ATT_OWN		BIT(1)
>  
> -/* address translation table */
> -struct imx_rproc_att {
> -	u32 da;	/* device address (From Cortex M4 view)*/
> -	u32 sa;	/* system bus address */
> -	u32 size; /* size of reg range */
> -	int flags;
> -};
> -
> -/* Remote core start/stop method */
> -enum imx_rproc_method {
> -	IMX_RPROC_NONE,
> -	/* Through syscon regmap */
> -	IMX_RPROC_MMIO,
> -	/* Through ARM SMCCC */
> -	IMX_RPROC_SMC,
> -};
> -
> -struct imx_rproc_dcfg {
> -	u32				src_reg;
> -	u32				src_mask;
> -	u32				src_start;
> -	u32				src_stop;
> -	const struct imx_rproc_att	*att;
> -	size_t				att_size;
> -	enum imx_rproc_method		method;
> -};
> -
>  struct imx_rproc {
>  	struct device			*dev;
>  	struct regmap			*regmap;
> diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h
> new file mode 100644
> index 000000000000..23d8e808d27f
> --- /dev/null
> +++ b/drivers/remoteproc/imx_rproc.h
> @@ -0,0 +1,37 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Copyright (c) 2017 Pengutronix, Oleksij Rempel <kernel@pengutronix.de>
> + * Copyright 2021 NXP
> + */
> +
> +#ifndef _IMX_RPROC_H
> +#define _IMX_RPROC_H
> +
> +/* address translation table */
> +struct imx_rproc_att {
> +	u32 da;	/* device address (From Cortex M4 view)*/
> +	u32 sa;	/* system bus address */
> +	u32 size; /* size of reg range */
> +	int flags;
> +};
> +
> +/* Remote core start/stop method */
> +enum imx_rproc_method {
> +	IMX_RPROC_NONE,
> +	/* Through syscon regmap */
> +	IMX_RPROC_MMIO,
> +	/* Through ARM SMCCC */
> +	IMX_RPROC_SMC,
> +};
> +
> +struct imx_rproc_dcfg {
> +	u32				src_reg;
> +	u32				src_mask;
> +	u32				src_start;
> +	u32				src_stop;
> +	const struct imx_rproc_att	*att;
> +	size_t				att_size;
> +	enum imx_rproc_method		method;
> +};
> +
> +#endif /* _IMX_RPROC_H */
> -- 
> 2.17.1
>