From: Doug Anderson <dianders@chromium.org>
To: Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-remoteproc@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Cc: Clement Leger <cleger@kalray.eu>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Evan Green <evgreen@chromium.org>
Subject: Re: [PATCH] remoteproc: Fix wrong rvring index computation
Date: Wed, 29 Apr 2020 16:26:41 -0700 [thread overview]
Message-ID: <CAD=FV=WgUNySbRE9dZys28fFo3eZwf_2=cj68jaw1ftakJDzVQ@mail.gmail.com> (raw)
In-Reply-To: <20191004073736.8327-1-cleger@kalray.eu>
Hi,
On Fri, 4 Oct 2019 Clement Leger <cleger@kalray.eu> wrote:
>
> Index of rvring is computed using pointer arithmetic. However, since
> rvring->rvdev->vring is the base of the vring array, computation
> of rvring idx should be reversed. It previously lead to writing at negative
> indices in the resource table.
>
> Signed-off-by: Clement Leger <cleger@kalray.eu>
> ---
> drivers/remoteproc/remoteproc_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Randomly stumbled upon this in a list of patches. This patch landed
in mainline as:
00a0eec59ddb remoteproc: Fix wrong rvring index computation
Should it be queued up for stable? I'm guessing:
Fixes: c0d631570ad5 ("remoteproc: set vring addresses in resource table")
-Doug
next prev parent reply other threads:[~2020-04-29 23:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 7:37 [PATCH] remoteproc: Fix wrong rvring index computation Clement Leger
2019-11-21 18:20 ` patchwork-bot+linux-remoteproc
2020-04-29 23:26 ` Doug Anderson [this message]
2020-04-30 6:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WgUNySbRE9dZys28fFo3eZwf_2=cj68jaw1ftakJDzVQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=cleger@kalray.eu \
--cc=evgreen@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).