From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Deepak Kumar Singh <deesin@codeaurora.org>
Cc: clew@codeaurora.org, mathieu.poirier@linaro.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 2/6] rpmsg: glink: Deny intent request if reusable intent fits
Date: Fri, 15 Oct 2021 10:14:16 -0500 [thread overview]
Message-ID: <YWmayBrhjGB+lvbU@builder.lan> (raw)
In-Reply-To: <1596086296-28529-3-git-send-email-deesin@codeaurora.org>
On Thu 30 Jul 00:18 CDT 2020, Deepak Kumar Singh wrote:
> From: Chris Lew <clew@codeaurora.org>
>
> In high traffic scenarios a remote may request extra intents to send
> data faster. If the work thread that handles these intent requests is
> starved of cpu time, then these requests can build up. Some remote
> procs may not be able to handle this burst of built up intent requests.
>
> In order to prevent intent build up, deny intent requests that can be
> fulfilled by default intents that are reusable.
>
> Signed-off-by: Chris Lew <clew@codeaurora.org>
> Signed-off-by: Deepak Kumar Singh <deesin@codeaurora.org>
> ---
> drivers/rpmsg/qcom_glink_native.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
> index 2668c66..df3c608 100644
> --- a/drivers/rpmsg/qcom_glink_native.c
> +++ b/drivers/rpmsg/qcom_glink_native.c
> @@ -734,9 +734,11 @@ static void qcom_glink_handle_rx_done(struct qcom_glink *glink,
> static void qcom_glink_handle_intent_req(struct qcom_glink *glink,
> u32 cid, size_t size)
> {
> - struct glink_core_rx_intent *intent;
> + struct glink_core_rx_intent *intent = NULL;
> + struct glink_core_rx_intent *tmp;
> struct glink_channel *channel;
> unsigned long flags;
> + int iid;
>
> spin_lock_irqsave(&glink->idr_lock, flags);
> channel = idr_find(&glink->rcids, cid);
> @@ -747,6 +749,19 @@ static void qcom_glink_handle_intent_req(struct qcom_glink *glink,
> return;
> }
>
> + spin_lock_irqsave(&channel->intent_lock, flags);
> + idr_for_each_entry(&channel->liids, tmp, iid) {
> + if (tmp->size >= size && tmp->reuse) {
> + intent = tmp;
> + break;
> + }
> + }
> + spin_unlock_irqrestore(&channel->intent_lock, flags);
> + if (intent) {
> + qcom_glink_send_intent_req_ack(glink, channel, !!intent);
This looks reasonable, but you know that !!intent is true in this block,
and looking more at it I think the end result would look better as:
/* Try to find a reusable intent to fit the request */
spin_lock()
intent = findit();
spin_unlock()
/* Allocate a new intent if none was found */
if (!intent) {
intent = qcom_glink_alloc_intent(glink, channel, size, false);
if (intent)
qcom_glink_advertise_intent(glink, channel, intent);
}
qcom_glink_send_intent_req_ack(glink, channel, !!intent);
Regards,
Bjorn
> + return;
> + }
> +
> intent = qcom_glink_alloc_intent(glink, channel, size, false);
> if (intent)
> qcom_glink_advertise_intent(glink, channel, intent);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2021-10-15 15:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 5:18 [PATCH V1 0/6] Glink native fixes upstreaming Deepak Kumar Singh
2020-07-30 5:18 ` [PATCH V1 1/6] rpmsg: glink: fix destroy channel endpoint logic Deepak Kumar Singh
2021-10-15 14:47 ` Bjorn Andersson
2020-07-30 5:18 ` [PATCH V1 2/6] rpmsg: glink: Deny intent request if reusable intent fits Deepak Kumar Singh
2021-10-15 15:14 ` Bjorn Andersson [this message]
2020-07-30 5:18 ` [PATCH V1 3/6] rpmsg: glink: Add TX_DATA_CONT command while sending Deepak Kumar Singh
2021-10-15 17:22 ` (subset) " Bjorn Andersson
2020-07-30 5:18 ` [PATCH V1 4/6] rpmsg: glink: Remove the rpmsg dev in close_ack Deepak Kumar Singh
2021-10-15 17:22 ` (subset) " Bjorn Andersson
2020-07-30 5:18 ` [PATCH V1 5/6] rpmsg: glink: Remove channel decouple from rpdev release Deepak Kumar Singh
2021-10-15 17:22 ` (subset) " Bjorn Andersson
2020-07-30 5:18 ` [PATCH V1 6/6] rpmsg: glink: Send READ_NOTIFY command in FIFO full case Deepak Kumar Singh
2021-10-15 17:22 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWmayBrhjGB+lvbU@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=deesin@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).