From: jacopo mondi <jacopo@jmondi.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
linux-sh@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 0/2] Remove calls to empty arch_setup_pdev_archdata()
Date: Fri, 18 May 2018 13:52:43 +0200 [thread overview]
Message-ID: <20180518115243.GA4432@w540> (raw)
In-Reply-To: <1526641611-2769-1-git-send-email-geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]
Hi Geert,
On Fri, May 18, 2018 at 01:06:49PM +0200, Geert Uytterhoeven wrote:
> Hi,
>
> Recently, a few calls to arch_setup_pdev_archdata() were added to the
> ecovec and migor board files (copied from platform_device_register())?
I suspect that was me
>
> However, SuperH doesn't implement arch_setup_pdev_archdata(), and falls
> back to the default (empty) implementation. As this code is
> board-specific, the calls can just be removed.
Thanks for looking into that.
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks
j
>
> Thanks!
>
> Geert Uytterhoeven (2):
> sh: ecovec: Remove calls to empty arch_setup_pdev_archdata()
> sh: migor: Remove calls to empty arch_setup_pdev_archdata()
>
> arch/sh/boards/mach-ecovec24/setup.c | 2 --
> arch/sh/boards/mach-migor/setup.c | 1 -
> 2 files changed, 3 deletions(-)
>
> --
> 2.7.4
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2018-05-18 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 11:06 [PATCH 0/2] Remove calls to empty arch_setup_pdev_archdata() Geert Uytterhoeven
2018-05-18 11:06 ` [PATCH 1/2] media: arch: sh: ecovec: " Geert Uytterhoeven
2018-05-22 8:22 ` Simon Horman
2018-05-18 11:06 ` [PATCH 2/2] media: arch: sh: migor: " Geert Uytterhoeven
2018-05-22 8:22 ` Simon Horman
2018-05-18 11:52 ` jacopo mondi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518115243.GA4432@w540 \
--to=jacopo@jmondi.org \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).