From: Simon Horman <horms@verge.net.au>
To: DUNG NGUYEN <dung.nguyen.aj@renesas.com>
Cc: Marek Vasut <marek.vasut@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] ARM: shmobile: Fix R-Car Gen2 regulator quirk
Date: Thu, 20 Dec 2018 16:44:37 +0900 [thread overview]
Message-ID: <20181220074437.44iq7n656tyqd5tt@verge.net.au> (raw)
In-Reply-To: <TY2PR01MB369237F587AA0FF04484E421D5BF0@TY2PR01MB3692.jpnprd01.prod.outlook.com>
On Thu, Dec 20, 2018 at 05:01:15AM +0000, DUNG NGUYEN wrote:
> > The quirk code currently detects all compatible I2C chips with a shared IRQ line
> > on all I2C busses, adds them into a list, and registers a bus notifier. For every
> > chip for which the bus notifier triggers, the quirk code performs I2C transfer on
> > that I2C bus for all addresses in the list.
> > The problem is that this may generate transfers to non-existing chips on
> > systems with multiple I2C busses.
> >
> > This patch adds a check to verify that the I2C bus to which the chip with shared
> > IRQ is attached to matches the I2C bus of the chip which triggered the bus
> > notifier and only starts the I2C transfer if they match.
> >
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Cc: Simon Horman <horms+renesas@verge.net.au>
> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Cc: linux-renesas-soc@vger.kernel.org
> > ---
> Hi Mr Marek
>
> Tested-by: Nguyen Viet Dung <dung.nguyen.aj@renesas.com>
>
> I have tested this patch on H2 Lager with mainline v4.20-rc4 kernel.
> Confirmed that the problem is improved by this patch.
>
> Best regards,
Thanks, applied for v4.22.
prev parent reply other threads:[~2018-12-20 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 20:28 [PATCH] ARM: shmobile: Fix R-Car Gen2 regulator quirk Marek Vasut
2018-12-10 12:08 ` Simon Horman
2018-12-20 5:01 ` DUNG NGUYEN
2018-12-20 7:44 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220074437.44iq7n656tyqd5tt@verge.net.au \
--to=horms@verge.net.au \
--cc=dung.nguyen.aj@renesas.com \
--cc=geert+renesas@glider.be \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).