linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Magnus <magnus.damm@gmail.com>, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 3/8] arm64: renesas: ulcb-kf: add pcm3168 sound codec
Date: Wed, 2 Jan 2019 10:35:02 +0100	[thread overview]
Message-ID: <20190102093502.y4vzyv5rsrdp3ak4@verge.net.au> (raw)
In-Reply-To: <87r2e59ky6.wl-kuninori.morimoto.gx@renesas.com>

On Wed, Dec 26, 2018 at 09:53:41AM +0900, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> KingFisher has pcm3168 sound codec. This patch enables it.
> Because pcm3168 can't handle symmetric channel on playback/
> capture, we need to handle it as different DAI.

Hi Morimoto-san,

as per my response to other patches in this series I have found,
hopefully, minor problems, when applying this patch.

When compiling I see:
# make W=1 dtbs
...

  DTC     arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dtb
  DTC     arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/i2c@e6510000/i2c-switch@71/i2c@7/audio-codec@44/ports/port@0: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/i2c@e6510000/i2c-switch@71/i2c@7/audio-codec@44/ports/port@1: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@2: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@3: node has a unit name, but no reg property
  DTC     arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dtb
  DTC     arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/i2c@e6510000/i2c-switch@71/i2c@7/audio-codec@44/ports/port@0: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/i2c@e6510000/i2c-switch@71/i2c@7/audio-codec@44/ports/port@1: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@2: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@3: node has a unit name, but no reg property
  DTC     arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dtb
  DTC     arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/i2c@e6510000/i2c-switch@71/i2c@7/audio-codec@44/ports/port@0: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/i2c@e6510000/i2c-switch@71/i2c@7/audio-codec@44/ports/port@1: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@2: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@3: node has a unit name, but no reg property
  DTC     arch/arm64/boot/dts/renesas/r8a77965-m3nulcb.dtb
  DTC     arch/arm64/boot/dts/renesas/r8a77965-m3nulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77965-m3nulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/i2c@e6510000/i2c-switch@71/i2c@7/audio-codec@44/ports/port@0: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a77965-m3nulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/i2c@e6510000/i2c-switch@71/i2c@7/audio-codec@44/ports/port@1: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a77965-m3nulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@2: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a77965-m3nulcb-kf.dtb: Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@3: node has a unit name, but no reg property

Locally the following seems to resolve this problem.
Please consider rolling this incremental change or another fix
into a v2 posting of this patchset.

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 401c166599a2..5cfa193fa8a9 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -163,14 +163,22 @@
 				VCCDA2-supply	= <&snd_vcc5v>;
 
 				ports {
+					#address-cells = <1>;
+					#size-cells = <0>;
 					mclk-fs = <512>;
+
 					port@0 {
+						reg = <0>;
+
 						pcm3168a_endpoint_p: endpoint {
 							remote-endpoint = <&rsnd_for_pcm3168a_play>;
 							clocks = <&clksndsel>;
 						};
 					};
+
 					port@1 {
+						reg = <1>;
+
 						pcm3168a_endpoint_c: endpoint {
 							remote-endpoint = <&rsnd_for_pcm3168a_capture>;
 							clocks = <&clksndsel>;
@@ -294,8 +302,13 @@
 		     &sound_pcm_pins>;
 
 	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
 		/* rsnd_port0/1 are on salvator-common */
 		rsnd_port2: port@2 {
+			reg = <2>;
+
 			rsnd_for_pcm3168a_play: endpoint {
 				remote-endpoint = <&pcm3168a_endpoint_p>;
 
@@ -307,7 +320,10 @@
 				playback = <&ssi3>;
 			};
 		};
+
 		rsnd_port3: port@3 {
+			reg = <3>;
+
 			rsnd_for_pcm3168a_capture: endpoint {
 				remote-endpoint = <&pcm3168a_endpoint_c>;
 

  reply	other threads:[~2019-01-02  9:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-26  0:52 [PATCH 0/8] arm64: renesas: Sound update for ULCB/KF, etc Kuninori Morimoto
2018-12-26  0:53 ` [PATCH 1/8] arm64: renesas: ulcb: use audio-graph-card Kuninori Morimoto
2019-01-02  9:34   ` Simon Horman
2018-12-26  0:53 ` [PATCH 2/8] arm64: renesas: ulcb: add HDMI sound support Kuninori Morimoto
2019-01-02  9:34   ` Simon Horman
2018-12-26  0:53 ` [PATCH 3/8] arm64: renesas: ulcb-kf: add pcm3168 sound codec Kuninori Morimoto
2019-01-02  9:35   ` Simon Horman [this message]
2019-01-07  0:54     ` Kuninori Morimoto
2018-12-26  0:53 ` [PATCH 4/8] arm64: renesas: r8a7795: remove BUSIF0 settings from rcar_sound,ssi Kuninori Morimoto
2018-12-26  0:53 ` [PATCH 5/8] arm64: renesas: r8a7796: " Kuninori Morimoto
2018-12-26  0:53 ` [PATCH 6/8] arm64: renesas: r8a77990-ebisu: use simple-audio-card Kuninori Morimoto
2018-12-26  0:54 ` [PATCH 7/8] arm64: defconfig: select Kingfisher Sound related configs Kuninori Morimoto
2018-12-26  0:54 ` [PATCH 8/8] arm64: renesas_defconfig: " Kuninori Morimoto
2018-12-27  1:57 ` [PATCH 0/8] arm64: renesas: Sound update for ULCB/KF, etc Simon Horman
2018-12-27  2:19   ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190102093502.y4vzyv5rsrdp3ak4@verge.net.au \
    --to=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).